Re: do I need "ifdef HAVE_UNISTD_H" if I import unistd?

2011-05-16 Thread Eric Blake
On 05/16/2011 04:13 PM, Sam Steingold wrote: >> VC_LIST_ALWAYS_EXCLUDE_REGEX = \ >> ^(ChangeLog|configure|config.in.h|aclocal.m4)$$ > > does not work either. > > also, this seems wrong because > > 1. when VC_LIST_ALWAYS_EXCLUDE_REGEX is used, it is put inside () It's working just fine for libv

Re: do I need "ifdef HAVE_UNISTD_H" if I import unistd?

2011-05-16 Thread Sam Steingold
> * Eric Blake [2011-05-16 15:57:43 -0600]: > > On 05/16/2011 03:56 PM, Sam Steingold wrote: >> >> from the way VC_LIST_ALWAYS_EXCLUDE_REGEX is used, this appears to be TRT: >> >> VC_LIST_ALWAYS_EXCLUDE_REGEX = ChangeLog|configure|config.in.h|aclocal.m4 > > | outside () is different than (|). T

Re: do I need "ifdef HAVE_UNISTD_H" if I import unistd?

2011-05-16 Thread Eric Blake
On 05/16/2011 03:56 PM, Sam Steingold wrote: > > from the way VC_LIST_ALWAYS_EXCLUDE_REGEX is used, this appears to be TRT: > > VC_LIST_ALWAYS_EXCLUDE_REGEX = ChangeLog|configure|config.in.h|aclocal.m4 | outside () is different than (|). Try: VC_LIST_ALWAYS_EXCLUDE_REGEX = \ ^(ChangeLog|confi

Re: do I need "ifdef HAVE_UNISTD_H" if I import unistd?

2011-05-16 Thread Sam Steingold
> * Eric Blake [2011-05-16 15:45:00 -0600]: > > On 05/16/2011 03:36 PM, Karl Berry wrote: >> > warnings about HAVE_ALLOCA_H in ChangeLog, aclocal.m4, and configure. >> >> Why should there ever be a warning about an occurrence of HAVE_ALLOCA_H >> in the ChangeLog? Just wondering. > > Only bec

Re: do I need "ifdef HAVE_UNISTD_H" if I import unistd?

2011-05-16 Thread Eric Blake
On 05/16/2011 03:44 PM, Sam Steingold wrote: >> * Eric Blake [2011-05-16 15:30:04 -0600]: >> >>> why doesn't vc-list-files accept a list of directories? >> >> Patches welcome; seems like a useful addition. > > @@ -61,16 +61,10 @@ EOF > shift; shift ;; > esac > > -dir= > -case $# in > -

Re: do I need "ifdef HAVE_UNISTD_H" if I import unistd?

2011-05-16 Thread Eric Blake
On 05/16/2011 03:36 PM, Karl Berry wrote: > > warnings about HAVE_ALLOCA_H in ChangeLog, aclocal.m4, and configure. > > Why should there ever be a warning about an occurrence of HAVE_ALLOCA_H > in the ChangeLog? Just wondering. Only because the filters haven't been tuned to exclude non-sourc

Re: do I need "ifdef HAVE_UNISTD_H" if I import unistd?

2011-05-16 Thread Sam Steingold
> * Eric Blake [2011-05-16 15:30:04 -0600]: > >> why doesn't vc-list-files accept a list of directories? > > Patches welcome; seems like a useful addition. --- /home2/sds/src/clisp/current/gnulib/build-aux/vc-list-files 2011-05-03 12:08:03.0 -0400 +++ /home2/sds/src/clisp/current/src/b

Re: do I need "ifdef HAVE_UNISTD_H" if I import unistd?

2011-05-16 Thread Karl Berry
> warnings about HAVE_ALLOCA_H in ChangeLog, aclocal.m4, and configure. Why should there ever be a warning about an occurrence of HAVE_ALLOCA_H in the ChangeLog? Just wondering.

Re: do I need "ifdef HAVE_UNISTD_H" if I import unistd?

2011-05-16 Thread Eric Blake
On 05/16/2011 03:16 PM, Sam Steingold wrote: >> * Eric Blake [2011-05-16 14:13:29 -0600]: >> >> Import that module, possibly add a cfg.mk counterpart (hmm, we >> probably ought to provide a template file for that; but you can use >> coreutils.git/cfg.mk for an idea of how it can be customized), us

Re: do I need "ifdef HAVE_UNISTD_H" if I import unistd?

2011-05-16 Thread Sam Steingold
> * Eric Blake [2011-05-16 14:13:29 -0600]: > > Import that module, possibly add a cfg.mk counterpart (hmm, we > probably ought to provide a template file for that; but you can use > coreutils.git/cfg.mk for an idea of how it can be customized), use GNU > make, and run 'make syntax-check' to catch

Re: do I need "ifdef HAVE_UNISTD_H" if I import unistd?

2011-05-16 Thread Eric Blake
On 05/16/2011 02:10 PM, Sam Steingold wrote: >> Absolutely! In fact, the maintainer-mode module includes the >> sc_prohibit_always_true_header_tests to help you check for files where >> you can unconditionally include headers guaranteed by gnulib replacements. > > there is no maintainer-mode in g

Re: do I need "ifdef HAVE_UNISTD_H" if I import unistd?

2011-05-16 Thread Sam Steingold
> * Eric Blake [2011-05-16 13:56:46 -0600]: > > On 05/16/2011 01:53 PM, Sam Steingold wrote: >> DIUC that if I include the sys_time & unistd modules, I can write >> >> #include >> #include >> >> instead of >> >> #ifdef HAVE_SYS_TIME_H >> #include >> #endif >> #ifdef HAVE_UNISTD_H >> #incl

Re: do I need "ifdef HAVE_UNISTD_H" if I import unistd?

2011-05-16 Thread Eric Blake
On 05/16/2011 01:53 PM, Sam Steingold wrote: > DIUC that if I include the sys_time & unistd modules, I can write > > #include > #include > > instead of > > #ifdef HAVE_SYS_TIME_H > #include > #endif > #ifdef HAVE_UNISTD_H > #include > #endif > > ?? > > the same question for all the othe

do I need "ifdef HAVE_UNISTD_H" if I import unistd?

2011-05-16 Thread Sam Steingold
DIUC that if I include the sys_time & unistd modules, I can write #include #include instead of #ifdef HAVE_SYS_TIME_H #include #endif #ifdef HAVE_UNISTD_H #include #endif ?? the same question for all the other headers... thanks! -- Sam Steingold (http://sds.podval.org/) on CentOS rel