Re: doc: Mention gnulib putenv module?

2024-05-17 Thread Collin Funk
On 5/17/24 2:38 AM, Bruno Haible wrote: > Now we can use the usual doc structure. > > > 2024-05-17 Bruno Haible > > putenv-gnu: Update documentation. > * doc/posix-functions/putenv.texi: Refer also to the glibc > documentation. Use the usual doc structure. Looks good.

Re: doc: Mention gnulib putenv module?

2024-05-17 Thread Bruno Haible
Collin Funk wrote: > Done in the two attached patches. Now we can use the usual doc structure. 2024-05-17 Bruno Haible putenv-gnu: Update documentation. * doc/posix-functions/putenv.texi: Refer also to the glibc documentation. Use the usual doc structure. diff --git

Re: doc: Mention gnulib putenv module?

2024-05-16 Thread Bruno Haible
> Done in the two attached patches. I ran the following in Coreutils: > > ./bootstrap --no-git --skip-po --gnulib-srcdir="$GNULIB_SRCDIR" > > and everything worked fine. Thanks a lot! Bruno

Re: doc: Mention gnulib putenv module?

2024-05-16 Thread Collin Funk
Hi Bruno, On 5/16/24 1:54 PM, Bruno Haible wrote: >> Thanks for the guide. > > And also update doc/posix-functions/putenv.texi. > >> Should I update occurrences of 'putenv' to >> 'putenv-gnu' in dependencies > > Yes. (But this can come in a second commit.) > >> and then mark 'putenv' with the

Re: doc: Mention gnulib putenv module?

2024-05-16 Thread Bruno Haible
Hi Collin, > On 5/16/24 5:45 AM, Bruno Haible wrote: > > The way to deal with it, that is most consistent with the rest of Gnulib, > > is as follows: > > > > - Rename the 'putenv' module to 'putenv-gnu'. > > > > - Also change its description from: > > putenv() function: change or add an

Re: doc: Mention gnulib putenv module?

2024-05-16 Thread Collin Funk
Hi Bruno, On 5/16/24 5:45 AM, Bruno Haible wrote: > The way to deal with it, that is most consistent with the rest of Gnulib, > is as follows: > > - Rename the 'putenv' module to 'putenv-gnu'. > > - Also change its description from: > putenv() function: change or add an environment

Re: doc: Mention gnulib putenv module?

2024-05-16 Thread Bruno Haible
Hi Collin, > > But maybe something could be clarified: > > - Does POSIX still not allow to remove an environment variable using > > this function? > > I don't think that POSIX Issue 7 disallows it [1]. It appears that the > behavior when '=' is not in the string is up for the

Re: doc: Mention gnulib putenv module?

2024-05-16 Thread Collin Funk
Hi Bruno, On 5/16/24 3:19 AM, Bruno Haible wrote: >> Is there a reason why the Gnulib putenv module isn't mentioned on this >> line or can I apply this diff with a ChangeLog entry? > > It is mentioned at the end of this file. I saw. I was thinking maybe it should be mentioned on that line

Re: doc: Mention gnulib putenv module?

2024-05-16 Thread Bruno Haible
Hi Collin, > Is there a reason why the Gnulib putenv module isn't mentioned on this > line or can I apply this diff with a ChangeLog entry? It is mentioned at the end of this file. But maybe something could be clarified: - Does POSIX still not allow to remove an environment variable using

doc: Mention gnulib putenv module?

2024-05-16 Thread Collin Funk
Is there a reason why the Gnulib putenv module isn't mentioned on this line or can I apply this diff with a ChangeLog entry? diff --git a/doc/posix-functions/putenv.texi b/doc/posix-functions/putenv.texi index b0ca4ab8b5..d9e15f5e38 100644 --- a/doc/posix-functions/putenv.texi +++