gnulib-tool incorrectly handles library names with dashes

2007-07-05 Thread Sergey Poznyakoff
Hello, When converting library names to Makefile variables, gnulib-tool forgets to convert dashes. The following patch fixes it. It also fixes unneeded duplication of --avoid options, notable in `# Reproduce by:' headers in generated Makefile.ams. No objections? Regards, Sergey 2007-07-05

Re: gnulib-tool incorrectly handles library names with dashes

2007-07-05 Thread Sergey Poznyakoff
Jim, Bruno, thank you. Gathering the bits together, I have rewritten the thing as follows: Index: gnulib-tool === RCS file: /cvsroot/gnulib/gnulib/gnulib-tool,v retrieving revision 1.245 diff -p -u -r1.245 gnulib-tool ---

Re: gnulib-tool incorrectly handles library names with dashes

2007-07-05 Thread Jim Meyering
Sergey Poznyakoff [EMAIL PROTECTED] wrote: Jim, Bruno, thank you. Gathering the bits together, I have rewritten the thing as follows: Index: gnulib-tool ... - libname_upper=`echo $libname | LC_ALL=C tr 'a-z' 'A-Z'` + libname_upper=`echo $libname | LC_ALL=C tr 'a-z-' 'A-Z_'` Looks

Re: gnulib-tool incorrectly handles library names with dashes

2007-07-05 Thread Sergey Poznyakoff
Jim Meyering [EMAIL PROTECTED] ha escrit: I know you didn't change the single quotes (maybe it's Bruno's stylistic preference to use them?), but they are superfluous. There's less syntax this way: libname_upper=`echo $libname | LC_ALL=C tr a-z- A-Z_` Yeah, but the quoted variant

Re: gnulib-tool incorrectly handles library names with dashes

2007-07-05 Thread Bruno Haible
Jim Meyering wrote: I know you didn't change the single quotes (maybe it's Bruno's stylistic preference to use them?) Yes, it's my stylistic preference. but they are superfluous. There's less syntax this way: libname_upper=`echo $libname | LC_ALL=C tr a-z- A-Z_` But it's not more

Re: gnulib-tool incorrectly handles library names with dashes

2007-07-05 Thread Jim Meyering
Bruno Haible [EMAIL PROTECTED] wrote: Jim Meyering wrote: I know you didn't change the single quotes (maybe it's Bruno's stylistic preference to use them?) Yes, it's my stylistic preference. but they are superfluous. There's less syntax this way: libname_upper=`echo $libname |