Re: gnupload: fix Shellcheck warnings

2018-11-28 Thread Ben Elliston
On Wed, Nov 28, 2018 at 10:40:05AM -0600, Eric Blake wrote: > > Or is this an independent fix? > > Hard to say. Note that: > > printf %s "\015" > printf %s "\\015" > > both output five bytes (single backslash, three digits, and a newline) - > that's because in "", \ followed by an unknown char

Re: gnupload: fix Shellcheck warnings

2018-11-28 Thread Eric Blake
On 11/28/18 10:00 AM, Bruno Haible wrote: Hi Ben, This patch silences some warnings from Shellcheck, mostly about using POSIX $(..) command substitutions instead of old backtick substitutions. The script starts with '#!/bin/sh'. /bin/sh on IRIX does not support $(...). But I think no GNU main

Re: gnupload: fix Shellcheck warnings

2018-11-28 Thread Bruno Haible
Hi Ben, > This patch silences some warnings from Shellcheck, mostly about using > POSIX $(..) command substitutions instead of old backtick > substitutions. The script starts with '#!/bin/sh'. /bin/sh on IRIX does not support $(...). But I think no GNU maintainer is using IRIX on their developmen

Re: gnupload: fix Shellcheck warnings

2018-11-28 Thread Darshit Shah
These changes look good to me in general. Always happy to see backticks removed and replaced with the new form. * Ben Elliston [181128 09:55]: > This patch silences some warnings from Shellcheck, mostly about using > POSIX $(..) command substitutions instead of old backtick > substitutions. > >

gnupload: fix Shellcheck warnings

2018-11-27 Thread Ben Elliston
This patch silences some warnings from Shellcheck, mostly about using POSIX $(..) command substitutions instead of old backtick substitutions. Cheers, Ben 2018-11-28 Ben Elliston * build-aux/gnupload: Fix some Shellcheck warnings. diff --git a/build-aux/gnupload b/build-aux/gnupload