Re: open MinGW failure

2010-01-12 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Removing the mingw* case in the 'case' statement is wrong, because the * case executes an AC_CACHE_CHECK which would yield 'no' when cross-compiling to mingw or natively compiling to mingw via wine but yield 'yes' when natively compiling to mingw via

Re: open MinGW failure

2010-01-11 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: The relevant code is: /* Cannot create directory. */ errno = 0; ASSERT (func (nonexist.ent/, O_CREAT | O_RDONLY, 0600) == -1); Open returns 3 for me, and it has created a file 'nonexist.ent'. This must be a bug in Wine, then. Please report

Re: open MinGW failure

2010-01-11 Thread Simon Josefsson
Paolo Bonzini bonz...@gnu.org writes: On 01/09/2010 12:33 PM, Bruno Haible wrote: Hmm, you and Paolo explained to me on 2009-08-21 that Wine should be considered as a platform of its own. But I still don't fully agree. Can you first report the bug to the Wine people and come back to patching

Re: open MinGW failure

2010-01-09 Thread Simon Josefsson
This problem was also caused by Wine, and not visible under Windows XP. See http://bugs.winehq.org/show_bug.cgi?id=21292 My old patch fixes the problem under Wine, but this updated patch adds a comment explaining. Ok to push? /Simon diff --git a/m4/open.m4 b/m4/open.m4 index d705b3a..bc04613

Re: open MinGW failure

2010-01-09 Thread Bruno Haible
Hi Simon, Simon Josefsson wrote: I got this when cross-compiling to MinGW with Wine: test-open.h:34: assertion failed FAIL: test-open.exe Whereas on a real Windows XP SP3, I get: skipping test: symlinks not supported on this file system SKIP: test-open.exe (which is a bit misleading:

Re: open MinGW failure

2010-01-09 Thread Bruno Haible
Simon Josefsson wrote: diff --git a/m4/open.m4 b/m4/open.m4 index d705b3a..bc04613 100644 --- a/m4/open.m4 +++ b/m4/open.m4 @@ -8,7 +8,7 @@ AC_DEFUN([gl_FUNC_OPEN], [ AC_REQUIRE([AC_CANONICAL_HOST]) case $host_os in -mingw* | pw*) +pw*) gl_REPLACE_OPEN ;;

Re: open MinGW failure

2010-01-09 Thread Paolo Bonzini
On 01/09/2010 12:33 PM, Bruno Haible wrote: Hmm, you and Paolo explained to me on 2009-08-21 that Wine should be considered as a platform of its own. But I still don't fully agree. Can you first report the bug to the Wine people and come back to patching gnulib only if they are not fixing it

open MinGW failure

2010-01-08 Thread Simon Josefsson
I got this when cross-compiling to MinGW with Wine: test-open.h:34: assertion failed FAIL: test-open.exe The relevant code is: /* Cannot create directory. */ errno = 0; ASSERT (func (nonexist.ent/, O_CREAT | O_RDONLY, 0600) == -1); Open returns 3 for me, and it has created a file