On Fri, Aug 19, 2016 at 1:48 PM, Pádraig Brady wrote:
> On 15/08/16 02:36, Assaf Gordon wrote:
>>
>>> On Aug 12, 2016, at 04:37, Pádraig Brady wrote:
>>>
>>> There's precedent for .2() versions of functions, like renameat2() etc.
>>> How about we pass an unsigned int flags, instead of bool, i
> On Aug 19, 2016, at 16:48, Pádraig Brady wrote:
>
> Looks good and pushed.
Thanks!
I'll send the coreutils' corresponding patch next.
regards,
- assaf
On 15/08/16 02:36, Assaf Gordon wrote:
>
>> On Aug 12, 2016, at 04:37, Pádraig Brady wrote:
>>
>> There's precedent for .2() versions of functions, like renameat2() etc.
>> How about we pass an unsigned int flags, instead of bool, in case we ever
>> need to extend in future?
>
> Attached a v
> On Aug 12, 2016, at 04:37, Pádraig Brady wrote:
>
> There's precedent for .2() versions of functions, like renameat2() etc.
> How about we pass an unsigned int flags, instead of bool, in case we ever
> need to extend in future?
Attached a version with 'unsigned in flags' instead of 'bool
On 12/08/16 04:38, Assaf Gordon wrote:
>> On Aug 10, 2016, at 05:59, Pádraig Brady wrote:
>>
>> Those look good to squash and apply,
>> modulo s/setftime/strftime/ in modules/parse-datetime
>
> Thank you for the review.
> Attached a squashed patch.
> I kept the name of the new function as 'parse_
> On Aug 10, 2016, at 05:59, Pádraig Brady wrote:
>
> Those look good to squash and apply,
> modulo s/setftime/strftime/ in modules/parse-datetime
Thank you for the review.
Attached a squashed patch.
I kept the name of the new function as 'parse_datetime2' (if that's acceptable).
Comments welco
On 10/08/16 05:07, Assaf Gordon wrote:
> Hello Paul, Pádraig,
>
> Thank you for the review and suggestions.
> Attached is a suggested draft patch to address some of the issues:
>
>> On Aug 9, 2016, at 12:32, Paul Eggert wrote:
>>
>> These days, there's little reason to use macros instead of stat
Hello Paul, Pádraig,
Thank you for the review and suggestions.
Attached is a suggested draft patch to address some of the issues:
> On Aug 9, 2016, at 12:32, Paul Eggert wrote:
>
> These days, there's little reason to use macros instead of static functions.
> So I suggest renaming DEBUG0 to de
Thanks for taking this on. Some comments.
These days, there's little reason to use macros instead of static functions. So
I suggest renaming DEBUG0 to debug0 and making it a static function, and
similarly for the other macros.
Also, the debug function should call gettext, instead of having it
FYI attached is a proposed patch from Assaf Gordon.
I'm about to apply this to the parse-datetime module to support diagnostic
output to help users.
This will be enabled soon from the coreutils date(1) util like:
$ TZ=America/Belize src/date --debug \
-d 'TZ="Asia/Tokyo" Su
10 matches
Mail list logo
