Re: [PATCH] argp: state that argp_error does not return

2017-09-08 Thread Paul Eggert
This change doesn't look right, since argp_error does return sometimes. How about fixing the problem entirely in the caller instead?

Re: max_align_t fails with clang 6.1 on OS X 10.10

2017-09-08 Thread Bruno Haible
Paul Eggert wrote: > Bruno Haible wrote: > > +} _gl_max_align_t; > > +#define max_align_t _gl_max_align_t > > #endif > > > > # endif /* _@GUARD_PREFIX@_STDDEF_H */ > > > > > > This one is not brittle and is not a big change. If Paul agrees, I would > > commit > > this, and you (Werner)

Re: gnulib-tool.py

2017-09-08 Thread Dmitry Selyutin
Hi Bruno, below is the sequence of commands. # creating a new branch on commit before pushing gnulib-tool $ git branch pygnulib-stable ec2d72558 # checking out branch and rebasing on the latest master changes $ git checkout pygnulib-stable $ git rebase master # cherry-picking only commits

Re: gnulib-tool.py

2017-09-08 Thread Darshit Shah
* Dmitry Selyutin [170908 16:39]: > Hi Bruno, > > below is the sequence of commands. > > # creating a new branch on commit before pushing gnulib-tool > $ git branch pygnulib-stable ec2d72558 > > # checking out branch and rebasing on the latest master changes > $ git

Re: [PATCH 1/2] fts: introduce the FTS_NOLEAF flag

2017-09-08 Thread Paul Eggert
On 09/08/2017 09:16 AM, Kamil Dudka wrote: The following linux commit seems to be related: Thanks, I installed the attached. >From ec768cc1b990d292975f166d8bcd878ca0f04e87 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 8 Sep 2017 09:35:53 -0700 Subject: [PATCH] *

Re: [PATCH 1/2] fts: introduce the FTS_NOLEAF flag

2017-09-08 Thread Kamil Dudka
On Friday, September 8, 2017 8:51:11 AM CEST Paul Eggert wrote: > > On 09/12/15 10:35, Pádraig Brady wrote: > >> p.s. I see that find does a stat per file on XFS, > >> while d_type can be used to distinguish dirs there. > >> On XFS DT_DIR is set for dirs and DT_UNKNOWN otherwise. > >> I wonder is

Re: gnulib-tool.py

2017-09-08 Thread Dmitry Selyutin
Yes, whitespaces and EOF's were the real cause. I've run the autopep8 tool and it solved the issue. Tim, I've managed to build wget2 against the latest master (though I had to change $gnulib_tool and checkout master inside submodule). 2017-09-08 17:51 GMT+03:00 Darshit Shah

gnulib-tool.py missing --dir option

2017-09-08 Thread Bruno Haible
gnulib-tool.py --help shows that a --dir option should be accepted, but it is not. $ ./gnulib-tool.py --dir=../testdir-dirent --create-testdir dirent usage: gnulib-tool.py --help ./gnulib-tool.py: error: unrecognized arguments: --dir=../testdir-dirent Here's the proposed fix. OK to push? >From

gnulib-tool.py argument parsing

2017-09-08 Thread Bruno Haible
Hi Dmitry, I'm banging my head against this: $ ./gnulib-tool.py --test dirent $ ./gnulib-tool.py --test --destdir=../testdir-dirent dirent usage: gnulib-tool.py --help ./gnulib-tool.py: error: unrecognized arguments: dirent The argument parsing

[PATCH] argp: state that argp_error does not return

2017-09-08 Thread Pavel Raiskup
Issue observed because the new GCC 7 -Wimplicit-fallthrough is whining when useless 'break;' is not specified after argp_error call. * lib/argp.h (__argp_error): Declare as _Noreturn. * lib/argp-help.c (__argp_error): Explicitly throw backtrace if the function was about to return. ---

Re: [PATCH 1/2] fts: introduce the FTS_NOLEAF flag

2017-09-08 Thread Paul Eggert
On 09/12/15 10:35, Pádraig Brady wrote: p.s. I see that find does a stat per file on XFS, while d_type can be used to distinguish dirs there. On XFS DT_DIR is set for dirs and DT_UNKNOWN otherwise. I wonder is there some optimization we could do for that case. There might be, but what are you