Re: [PATCH] gnulib-tool.py: Fix output of #include directive advice.

2024-03-25 Thread Bruno Haible
Hi Collin, > This patch fixes the following test failure: > > ./test-emacs-1.out tmp52599-out differ: byte 37757, line 896 > --- ./test-emacs-1.out2024-03-24 03:30:48.285074696 -0700 > +++ tmp52599-out 2024-03-25 02:01:39.966937097 -0700 > @@ -893,6 +893,10 @@ > Finished. > >

[PATCH] gnulib-tool.py: Fix output of #include directive advice.

2024-03-25 Thread Collin Funk
This patch fixes the following test failure: ./test-emacs-1.out tmp52599-out differ: byte 37757, line 896 --- ./test-emacs-1.out 2024-03-24 03:30:48.285074696 -0700 +++ tmp52599-out2024-03-25 02:01:39.966937097 -0700 @@ -893,6 +893,10 @@ Finished. You may need to add #include

Re: [PATCH] gnulib-tool.py: Handle removed files in the vc ignore files.

2024-03-25 Thread Bruno Haible
Hi Collin, > Thanks. I've attached a *very* rough patch that I think works > similarly to gnulib-tool.sh if you would like to take a look at it. Looks pretty good. I'm applying it, together with a follow-up below: - Your ability to work with misnamed variables is amazing. But nonetheless

Re: [PATCH] gnulib-tool.py: Fix "Creating directory" output.

2024-03-25 Thread Bruno Haible
Hi Collin, > This patch fixes this test failure: > > ./test-hello-c-gnulib-nonrecursive-1.out tmp1016386-out differ: byte 2612, > line 147 > --- ./test-hello-c-gnulib-nonrecursive-1.out 2024-03-24 03:30:48.391074752 > -0700 > +++ tmp1016386-out2024-03-24 18:33:30.855703830 -0700 > @@

gnulib-tool.py: Print "executing mkdir ..." messages

2024-03-25 Thread Bruno Haible
This test failure: $ GNULIB_TOOL_IMPL=py ./test-create-megatestdir-1.sh ./test-create-megatestdir-1.out tmp3004461-out differ: byte 47492, line 2144 --- ./test-create-megatestdir-1.out 2024-03-19 17:15:42.776229407 +0100 +++ tmp3004461-out 2024-03-25 14:54:20.378618846 +0100 @@ -2141,6

Re: [PATCH] gnulib-tool.py: Fix "Creating directory" output.

2024-03-25 Thread Collin Funk
Hi Bruno, On 3/25/24 5:20 AM, Bruno Haible wrote: > You don't need this trick here, since we sort this part of the list > anyway, for compatibility with gnulib-tool.sh. > > This occurred also with the EXTRA_DIST augmentations: Oops, you are right. It is easy for me to forget where things are

jit/cache: Fix a compilation error on Solaris 11.4/SPARC

2024-03-25 Thread Bruno Haible
On Solaris 11.4/SPARC, with gcc, I see this compilation error: gcc -O2 -DHAVE_CONFIG_H -DEXEEXT=\"\" -DEXEEXT=\"\" -I. -I../../gltests -I.. -DGNULIB_STRICT_CHECKING=1 -DIN_GNULIB_TESTS=1 -I. -I../../gltests -I.. -I../../gltests/.. -I../gllib -I../../gltests/../gllib

[PATCH] gnulib-tool.py: Only process configure.ac once.

2024-03-25 Thread Collin Funk
Hi Bruno, On 3/19/24 2:23 AM, Bruno Haible wrote: > One point needs attention, still: In gnulib-tool.sh the code looks at > configure.ac and, if that does not exist, at configure.in: > > # Prefer configure.ac to configure.in. > if test -f "$destdir"/configure.ac; then >

Re: [PATCH] gnulib-tool.py: Handle removed files in the vc ignore files.

2024-03-25 Thread Collin Funk
Hi Bruno, On 3/25/24 5:00 AM, Bruno Haible wrote: > - Your ability to work with misnamed variables is amazing. But > nonetheless let's make an effort to find better names :) LOL, I appreciate the compliment, but yes I agree better naming is good. > - Python has enough string processing

Re: [PATCH] gnulib-tool.py: Fix output of #include directive advice.

2024-03-25 Thread Collin Funk
On 3/25/24 5:45 AM, Bruno Haible wrote: > I don't see it as misleading. In test-wget2-1.out, the '#include > ' > occurs a second time, but that's for a good reason. Ah, I meant to check that. I didn't see it occurred in wget2. Thanks! > Thanks, applied with a tweak. (One could alternatively use

gettime-res failure on Solaris 11/SPARC

2024-03-25 Thread Bruno Haible
Hi Paul, On the new cfarm machine cfarm216.cfarm.net (Solaris 11.4, SPARC), the gettime-res test frequently fails, both in 32-bit and in 64-bit mode: $ ./test-gettime-res gettime_res returned 5 ns $ ./test-gettime-res gettime_res returned 5 ns current_timespec returned 1711414997.052976757 which

Re: gettime-res failure on Solaris 11/SPARC

2024-03-25 Thread Paul Eggert
On 3/25/24 18:10, Bruno Haible wrote: What shall we do with this one? Override gettime_res() to return 1 ns instead of 5 ns? Or adapt the unit test? Perhaps overriding is best. I'm a bit puzzled why the current code doesn't work, though.

[PATCH] gnulib-tool.py: Fix sorting of modules when --local-dir is used.

2024-03-25 Thread Collin Funk
The Coreutils test case fails because of this diff (in part at least): --- ./test-coreutils-1.result/m4/gnulib-comp.m4 2024-03-25 19:19:30.371888468 -0700 +++ tmp116344-result/m4/gnulib-comp.m4 2024-03-25 20:17:01.642173500 -0700 @@ -42,6 +42,7 @@ AC_REQUIRE([gl_USE_SYSTEM_EXTENSIONS])