Re: AC_COMPILE_IFELSE

2008-03-06 Thread Ralf Wildenhues
Hello Bruno, Simon, * Bruno Haible wrote on Thu, Mar 06, 2008 at 12:47:31PM CET: Simon Josefsson wrote: I find AC_TRY_COMPILE slightly easier to work with than AC_COMPILE_IFELSE so perhaps we could argue that it should be non-deprecated, unless there were a strong reason to deprecate it.

Re: AC_COMPILE_IFELSE

2008-03-06 Thread Bruno Haible
Simon Josefsson wrote: I find AC_TRY_COMPILE slightly easier to work with than AC_COMPILE_IFELSE so perhaps we could argue that it should be non-deprecated, unless there were a strong reason to deprecate it. Likewise for me. AC_TRY_COMPILE has a more mnemonic name (it follows the usual rule to

Re: lock module question

2008-03-06 Thread Simon Josefsson
Bruno Haible [EMAIL PROTECTED] writes: Using -pthread allow option like -D_REENTRANT to be defined when compiling Gnulib, which sound like a requirement if the program using Gnulib is multithreaded. Neither -pthread nor -D_REENTRANT is a requirement for building multithreaded programs on

Re: __func__

2008-03-06 Thread Simon Josefsson
Eric Blake [EMAIL PROTECTED] writes: According to Simon Josefsson on 3/4/2008 7:39 AM: | | However, what do you think about this? | | /Simon | |From 232f8a7255f8addd9724156d7d245b51a7feb72e Mon Sep 17 00:00:00 2001 | From: Simon Josefsson [EMAIL PROTECTED] | Date: Tue, 4 Mar 2008

Re: Add pdf target in doc/.

2008-03-06 Thread Simon Josefsson
[EMAIL PROTECTED] (Karl Berry) writes: got a 'TeX capacity exceeded, sorry [save size=5000].' error. Increasing 'save_size' in texmf.cnf solved it. FWIW, I increased it to 5 for the next TeX Live release. I don't recall exactly why, but maybe because I ran into exactly the

Re: __func__

2008-03-06 Thread Bruno Haible
Simon Josefsson wrote: + * doc/gnulib.texi (__func__): Section renamed to func. + * doc/gnulib.texi (__func__): Document __func__ module. I moved out this documentation to a separate file. This will make it easier in the future to do reorganizations of the manual. Bruno 2008-03-06

Re: __func__

2008-03-06 Thread Simon Josefsson
Jim Meyering [EMAIL PROTECTED] writes: Simon Josefsson [EMAIL PROTECTED] wrote: Eric Blake [EMAIL PROTECTED] writes: ... Maybe it's just me, but I hate typing _ (it involves a shift key and some coordination). Can we name it modules/func rather than modules/__func__? Hi Simon, Ouch, I

Re: __func__

2008-03-06 Thread Jim Meyering
Simon Josefsson [EMAIL PROTECTED] wrote: Eric Blake [EMAIL PROTECTED] writes: ... Maybe it's just me, but I hate typing _ (it involves a shift key and some coordination). Can we name it modules/func rather than modules/__func__? Hi Simon, Ouch, I have already pushed it. Should we rename

Re: __func__

2008-03-06 Thread Simon Josefsson
Simon Josefsson [EMAIL PROTECTED] writes: Jim Meyering [EMAIL PROTECTED] writes: Simon Josefsson [EMAIL PROTECTED] wrote: Eric Blake [EMAIL PROTECTED] writes: ... Maybe it's just me, but I hate typing _ (it involves a shift key and some coordination). Can we name it modules/func rather

Re: multithread modules

2008-03-06 Thread Bruno Haible
Simon Josefsson wrote: Hm. lock.m4 contains: # For using pthread.h: case $host_os in osf*) # On OSF/1, the compiler needs the flag -D_REENTRANT so that it # groks pthread.h. cc also understands the flag -pthread, but # we don't use it because 1.

suggestion: move Gnulib module: -- blurb to misc notes

2008-03-06 Thread Thien-Thi Nguyen
Presently, the blurb: |The notation ``Gnulib module: ---'' means that Gnulib does not provide a |module providing a substitute for the function. When the list |``Portability problems not fixed by Gnulib'' is empty, such a module is |not needed: No portability problems are known. Otherwise, it

[patch] doc/gnulib-too.texi

2008-03-06 Thread Thien-Thi Nguyen
A tiny change. (Is there a more preferred format for patches?) thi __ doc/gnulib-tool.texi |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/doc/gnulib-tool.texi b/doc/gnulib-tool.texi index 9d9ec56..f5a66e0

Re: closein, freadahead and ungetc

2008-03-06 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 2/29/2008 6:36 AM: | According to Bruno Haible on 2/29/2008 3:49 AM: | | With strace you can see that there is only a single read() from the file | | descriptor. I.e. at the moment when freadahead() returns 0, it is only |

Re: AC_COMPILE_IFELSE

2008-03-06 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 3/6/2008 6:49 AM: | When I write a piece of C code (INCLUDES or FUNCTION-BODY), in 99% of the cases | I want brackets to denote array dimensions or array indices. I don't want them | to expand to nothing. | | You say that

Re: AC_COMPILE_IFELSE

2008-03-06 Thread Bruno Haible
Hello Ralf, I wrote: AC_TRY_COMPILE has a more mnemonic name (it follows the usual rule to use an English verb to as a function/macro name) and simpler quoting rules than AC_COMPILE_IFELSE. Also, AC_COMPILE_IFELSE presents a pitfall: One is tempted to write AC_COMPILE_IFELSE([

Re: suggestion: move Gnulib module: -- blurb to misc notes

2008-03-06 Thread Bruno Haible
Hi, Thien-Thi Nguyen wrote: Presently, the blurb: |The notation ``Gnulib module: ---'' means ... is in @node Function Substitutes, which comes after usage of that notation in the preceding @node Header File Substitutes. You're right, this is not so good. I think it would good to move

Re: [patch] doc/gnulib-too.texi

2008-03-06 Thread Thien-Thi Nguyen
() Bruno Haible [EMAIL PROTECTED] () Thu, 6 Mar 2008 15:01:18 +0100 Thanks, I've applied a slightly different one. (I don't often read about registering with the VCS. check in is the more common term. Also, when you say marked as ignorable (for example, by adding them to

Re: [patch] doc/gnulib-too.texi

2008-03-06 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Thien-Thi Nguyen on 3/6/2008 7:13 AM: | So i take it context diff is preferred for code patches? Either form works for either case. But for readability purposes, documentation patches tend to modify sentences, and it is nice to see the

Re: [patch] doc/gnulib-too.texi

2008-03-06 Thread Bruno Haible
Hi, Thien-Thi Nguyen wrote: A tiny change. Thanks, I've applied a slightly different one. (I don't often read about registering with the VCS. check in is the more common term. Also, when you say marked as ignorable (for example, by adding them to @file{.cvsignore} - are there other ways to mark

Re: unified diff and context diff

2008-03-06 Thread Ben Pfaff
Bruno Haible [EMAIL PROTECTED] writes: There's also a program 'ud2cd' which converts a unified diff to a context diff a posteriori, and 'cd2ud' which converts a context diff to a unified diff. [1] Emacs diff-mode can also convert between unified and context diffs. -- Ben Pfaff

Re: unified diff and context diff

2008-03-06 Thread Bruno Haible
Eric Blake wrote: Either form works for either case. But for readability purposes, documentation patches tend to modify sentences, and it is nice to see the before and after effect of a partial sentence without having lots of lines in between. And code patches tend to modify logical blocks

Re: suggestion: move Gnulib module: -- blurb to misc notes

2008-03-06 Thread Thien-Thi Nguyen
() Bruno Haible [EMAIL PROTECTED] () Thu, 6 Mar 2008 15:04:12 +0100 Hmm, I would prefer to copy this paragraph to the beginning of each of the 4 header file / function substitutes chapters. Without this paragraph, people did not understand what the notation means. Sounds reasonable.

Re: suggestion: move Gnulib module: -- blurb to misc notes

2008-03-06 Thread Bruno Haible
Thien-Thi Nguyen wrote: Below is a patch. Thank you. I applied it, except for the additional paragraph break. 2008-03-06 Thien-Thi Nguyen [EMAIL PROTECTED] * doc/gnulib-tool.texi (@nosuchmodulenote): New macro. (Header File Substitutes, Function Substitutes, Glibc

Re: suggestion: move Gnulib module: -- blurb to misc notes

2008-03-06 Thread Thien-Thi Nguyen
() Bruno Haible [EMAIL PROTECTED] () Thu, 6 Mar 2008 18:46:47 +0100 [...] additional paragraph break. Drat, i knew i should have explained that. I added it to avoid the resulting info file displaying the email address at end-of-paragraph split accross two lines, (ugly IMHO). Ah well, a

more users

2008-03-06 Thread Bruno Haible
libgnupdf now also uses gnulib. *** users.txt.orig 2008-03-06 19:40:09.0 +0100 --- users.txt 2008-03-06 19:34:19.0 +0100 *** *** 26,31 --- 26,32 inetutils http://cvs.sv.gnu.org/viewcvs/inetutils/inetutils/ jwhois

Re: suggestion: move Gnulib module: -- blurb to misc notes

2008-03-06 Thread Bruno Haible
Thien-Thi Nguyen wrote: to avoid the resulting info file displaying the email address at end-of-paragraph split accross two lines, (ugly IMHO). There's a particular texinfo command for this: @w{}. 2008-03-06 Bruno Haible [EMAIL PROTECTED] * doc/gnulib-tool.texi (@nosuchmodulenote):

Re: suggestion: move Gnulib module: -- blurb to misc notes

2008-03-06 Thread Thien-Thi Nguyen
() Bruno Haible [EMAIL PROTECTED] () Thu, 6 Mar 2008 19:51:36 +0100 There's a particular texinfo command for this: @w{}. Cool. thi

Re: lock module question

2008-03-06 Thread Yoann Vandoorselaere
Le mercredi 05 mars 2008 à 18:06 +0100, Bruno Haible a écrit : Yoann Vandoorselaere asked: Is it expected that the lock module does not set the -pthread CFLAGS when compiling with GCC on a Linux architecture? Yes it is normal. The module description has this, and gnulib-tool echoes it:

Re: multithread modules

2008-03-06 Thread Yoann Vandoorselaere
Le jeudi 06 mars 2008 à 14:10 +0100, Bruno Haible a écrit : Simon Josefsson wrote: Hm. lock.m4 contains: # For using pthread.h: case $host_os in osf*) # On OSF/1, the compiler needs the flag -D_REENTRANT so that it # groks pthread.h. cc also

Re: closein, freadahead and ungetc

2008-03-06 Thread Bruno Haible
Eric Blake wrote: After more thought, I think we need an API change to freadahead, to add a flag parameter. When the flag is 0, return the number of bytes available in the current buffer that freadptr would return. When the flag is non-zero, return the number of bytes available prior to the

fseeko: missing declaration on glibc systems

2008-03-06 Thread Bruno Haible
Testing the 'fflush' module on a Linux/x86 systems, I got this warning: test-fflush.c: Dans la fonction « main »: test-fflush.c:103: Warnung: implicit declaration of function `fseeko' This fixes it. Committed. 2008-03-06 Bruno Haible [EMAIL PROTECTED] * modules/fseeko

Re: fflush after ungetc

2008-03-06 Thread Bruno Haible
Eric Blake wrote on Saturday: Newlib has two bugs - first, fflush is failing to discard ungetc data when changing the underlying fd offset. Do you know the wording that the newest POSIX has about this? The following test program, run on various platforms, gives unconclusive results.

Re: lock module question

2008-03-06 Thread Bruno Haible
Yoann, Neither -pthread nor -D_REENTRANT is a requirement for building multithreaded programs on Linux with glibc. Can you confirm the validity of this statement for the old linuxthread implementation? For the things that I have tested, yes. I'm doing most of my development on a Linux

Re: multithread modules

2008-03-06 Thread Bruno Haible
Yoann Vandoorselaere wrote: Reading the documentation, I can see: Also sets PTHREAD_CC to any special C compiler that is needed for multi-threaded programs (defaults to the value of CC otherwise). (This is necessary on AIX to use the special cc_r compiler alias.) I don't think that it is

Re: fseeko: missing declaration on glibc systems

2008-03-06 Thread Eric Blake
Bruno Haible bruno at clisp.org writes: This fixes it. Committed. 2008-03-06 Bruno Haible bruno at clisp.org * modules/fseeko (Dependencies): Add extensions. * m4/fseeko.m4 (gl_FUNC_FSEEKO): Require AC_USE_SYSTEM_EXTENSIONS. Needed on glibc systems. And for symmetry,

Re: fflush after ungetc

2008-03-06 Thread Bruno Haible
Eric Blake wrote: Newlib has two bugs - first, fflush is failing to discard ungetc data when changing the underlying fd offset. This bug is common to all BSD and ATT Unix derived implementations. For BSD systems, I'm committing this fix. For ATT Unix derived implementations, I don't see an easy

Re: Cygwin ftell bug

2008-03-06 Thread Bruno Haible
Eric Blake wrote: Second, ftell is improperly calling fflush under the hood, which when coupled with the first bug, results in a confused file offset, but even when the first bug is fixed, loses data contrary to POSIX. Can you please document it in gnulib/doc/? Bruno

Re: fflush after ungetc

2008-03-06 Thread Eric Blake
Bruno Haible bruno at clisp.org writes: Eric Blake wrote on Saturday: Newlib has two bugs - first, fflush is failing to discard ungetc data when changing the underlying fd offset. Do you know the wording that the newest POSIX has about this? The ungetc wording is unchanged from POSIX

vms uid handlng for tar 1.19

2008-03-06 Thread John E. Malmberg
The next test for me to get working is options.at. The issue is that the VMS UID is 32 bits with the GID encoded in it, unless special mapping is in place. So to encode the UID in uid_to_chars(), the value needed is (uid 16) unless the special mapping is in place, in which case the UID