Re: module include recommendation

2010-01-26 Thread Jim Meyering
Eric Blake wrote: I noticed this while bootstrapping m4; ignore-value.h stood out like a sore thumb when sorted among the list of system headers, when all other gnulib- specific headers used by m4 used . Any objections to this patch? I did not touch eealloc, although that is another module

[PATCH] test-userspec.c: avoid compiler warnings

2010-01-26 Thread Jim Meyering
FYI, my new test added a lot of warnings. This change addresses all of them. From 1c9217c42e20cb34140f66b58bca543fd14c4aea Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Tue, 26 Jan 2010 09:51:26 +0100 Subject: [PATCH] test-userspec.c: avoid compiler warnings *

Re: [Bug-tar] getline() differences FreeBSD / GNU libc

2010-01-26 Thread Eric Blake
[adding bug-gnulib, as the source of tar's getline replacement] According to noordsij on 1/21/2010 6:37 AM: Dear GNU tar maintainer(s) / fBSD gtar port maintainer(s), The problem appears to be a difference in getline() behaviour in the fBSD and GNU libc. fBSD: The caller may provide

Re: xctime()

2010-01-26 Thread Robert Millan
On Mon, Jan 25, 2010 at 10:57:07AM +0100, Bruno Haible wrote: Robert Millan wrote: - In the average case, you can get away with 1 strftime call instead of 2, if you preallocate a buffer on the stack: char buf[256]; len = strftime (buf, sizeof (buf), %c, loctime)

Re: git checkout

2010-01-26 Thread Bruno Haible
[Original problem report in [1].] See on the hydra build:http://hydra.nixos.org/build/256086 Hydra creates its tarballs not directly from the git checkout, but by running in particular make dist in the git checkout.[2] This has caused problems also in other packages. Specifically in autoconf:

Re: xctime()

2010-01-26 Thread Bruno Haible
Robert Millan wrote: Ok then. But if I preallocate a buffer on the stack, then xctime() can't return it. Of course it cannot return a pointer to an array in its own stack frame. You want to write a function that executes strftime and returns its result in freshly allocated memory. You can