Re: gnulib-tool and --with-tests

2012-06-22 Thread Thien-Thi Nguyen
() Bruno Haible br...@clisp.org () Thu, 21 Jun 2012 22:46:02 +0200 gnulib-tool: --create-[mega]testdir, --[mega]test implies --with-tests. Apparently, ‘--with-tests’ is implied (somehow) by ‘--update’ as well (but that is incompatible (why?) with ‘--conditional-dependencies’):

fbufmode: fix test

2012-06-22 Thread Bruno Haible
The musl people reported that gnulib's fbuftest was testing undefined behaviour according to the ISO C standard: http://www.openwall.com/lists/musl/2012/06/17/9 http://www.openwall.com/lists/musl/2012/06/17/10 This fixes it. 2012-06-22 Bruno Haible br...@clisp.org fbufmode test: Don't

Re: grantpt test

2012-06-22 Thread Bruno Haible
Rich Felker wrote: test-grantpt.c:34: assertion failed FAIL: test-grantpt This is an invalid test. POSIX specifies this function may fail, not shall fail, and since the function is inherently a no-op, it would be idiotic to make it perform a syscall to check the validity of the file

Re: new module: relpath

2012-06-22 Thread Akim Demaille
Hi Eli, Le 19 juin 2012 à 17:51, Eli Zaretskii a écrit : From: Akim Demaille a...@lrde.epita.fr Date: Tue, 19 Jun 2012 14:15:19 +0200 Cc: Eric Blake ebl...@redhat.com, bug-gnulib@gnu.org Maybe I'm looking at the wrong source file in gnulib. but I see these at the beginning of

Re: new module: relpath

2012-06-22 Thread Eric Blake
On 06/22/2012 06:02 AM, Akim Demaille wrote: Still, I have been asked to address many issues in relpath before a possible integration. One issue was making it library-ready, which I partly did by eliminating xalloc.h. But there are other issues, including the fact that relpath relies on

Re: new module: relpath

2012-06-22 Thread Jim Meyering
Akim Demaille wrote: Before addressing other issues in my proposal, I would like to know if everybody agrees that being lgpl, being xalloc/error free, etc. is irrelevant for relpath? Hi Akim, You've hit the nail on the head. Making this new module and all of its dependents xalloc/error-free

[PATCH] time_r: fix typo that always overrode localtime_r decl

2012-06-22 Thread Paul Eggert
ChangeLog|7 +++ m4/time_r.m4 |2 +- 2 files changed, 8 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index a12bccf..74354d5 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2012-06-22 Paul Eggert egg...@cs.ucla.edu + + time_r: fix typo that

Re: gnulib-tool and --with-tests

2012-06-22 Thread Bruno Haible
Thien-Thi Nguyen wrote: gnulib-tool: --create-[mega]testdir, --[mega]test implies --with-tests. Apparently, ‘--with-tests’ is implied (somehow) by ‘--update’ as well In --update mode, the settings come from the gnulib-cache.m4 file, in your case it's here:

Re: [PATCH] time_r: fix typo that always overrode localtime_r decl

2012-06-22 Thread Bruno Haible
Paul Eggert wrote: + time_r: fix typo that always overrode localtime_r decl The mistake was mine, sorry. But the effect was harmless: gnulib's time.h was merely providing a redundant declaration. Also, not all platforms were affected: In past build logs, I can see checking whether