[PATCH] renameat2: port better to macOS

2017-08-15 Thread Paul Eggert
* lib/renameat2.c (renameat2): Use renameatx_np if available. --- ChangeLog | 3 +++ lib/renameat2.c | 20 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index bc0c16991..e4fe8dd61 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5

Re: test results on NetBSD 7.0

2017-08-15 Thread Paul Eggert
Bruno Haible wrote: Test results of a Gnulib POSIX testdir on NetBSD 7.0: Thanks for doing that. Although I don't know about the math problems, here are thoughts on the file-related issues. FAIL: test-futimens === ../../gltests/test-futimens.h:154: assertion 'ctime_compare

Re: workaround against broken duplocale

2017-08-15 Thread Joerg Sonnenberger
On Tue, Aug 15, 2017 at 11:39:38PM +0200, Bruno Haible wrote: > Hi Jörg, > > Joerg Sonnenberger wrote: > > uselocale() is fundamentally broken from a design perspective. It can't > > be implemented without breaking ABIs. > > Well, glibc did not break ABIs when it introduced uselocale() in 2002.

Re: workaround against broken duplocale

2017-08-15 Thread Bruno Haible
Hi Jörg, Joerg Sonnenberger wrote: > uselocale() is fundamentally broken from a design perspective. It can't > be implemented without breaking ABIs. Well, glibc did not break ABIs when it introduced uselocale() in 2002. If you have not exposed too many internals of the locale set by setlocale(),

test results on NetBSD 7.0

2017-08-15 Thread Bruno Haible
Test results of a Gnulib POSIX testdir on NetBSD 7.0: 1) On both x86 and x86_64 FAIL: test-exp2l ../../gltests/test-exp2.h:50: assertion 'z == y' failed FAIL test-exp2l (exit status: 134) FAIL: test-expm1l = ../../gltests/test-expm1.h:80: assertion 'err > -

renameat declaration on NetBSD 7.0

2017-08-15 Thread Bruno Haible
On NetBSD 7.0, I'm seeing this test compilation failure: gcc -std=gnu99 -DHAVE_CONFIG_H -DEXEEXT=\"\" -I. -I../../gltests -I.. -DGNULIB_STRICT_CHECKING=1 -DIN_GNULIB_TESTS=1 -I. -I../../gltests -I.. -I../../gltests/.. -I../gllib -I../../gltests/../gllib -I/home/bruno/include -Wall

Re: workaround against broken duplocale

2017-08-15 Thread Joerg Sonnenberger
On Tue, Aug 15, 2017 at 09:28:26PM +0200, Bruno Haible wrote: > Which is pretty senseless, since it forces programs to use functions that take > an explicit locale argument (fprintf_l, strfmon_l, and similar). The point > of standardizing duplocale(), newlocale(), uselocale() was to *eliminate* >

workaround against broken duplocale

2017-08-15 Thread Bruno Haible
Hi, Running a gnulib testdir on NetBSD, I'm seeing a link error for test-duplocale. This is due to the fact that the NetBSD people implemented duplocale() without uselocale(). https://mail-index.netbsd.org/tech-userlevel/2013/04/23/msg007714.html Which is pretty senseless, since it forces

Re: O_NOFOLLOW on NetBSD

2017-08-15 Thread Bruno Haible
Paul Eggert wrote: > https://ftp.netbsd.org/pub/NetBSD/NetBSD-current/src/sys/sys/featuretest.h > > says that defining _NETBSD_SOURCE should be helpful only if _ANSI_SOURCE, > _POSIX_SOURCE, _POSIX_C_SOURCE, or _XOPEN_SOURCE is defined. I suppose it > shouldn't hurt to define _NETBSD_SOURCE, to

Re: Feature Request: Implement glibc reallocarray() function

2017-08-15 Thread Darshit Shah
* Bruno Haible [170814 21:41]: Hi Darshit, Thank you very much for your patience, to go through these details for your first major gnulib contributions! I appreciate it a lot. Bruno I'd like to thank everyone here who helped me along the way making sure that the patch was