Re: link error with libgcrypt

2017-10-29 Thread Jia Zhang
于 2017/10/29 下午11:00, Bruno Haible 写道: > Hi Jia, > >> I will still have a link failure with crypto/gc-sm3 and even >> crypto/gc. >> >> In order to reproduce this link failure, I need to have a latest >> libgcrypt installed, and then configure gnulib in this way: >> >> $ ./gnulib-tool

Re: latest gcc vs lib/timespec.h:85

2017-10-29 Thread Jim Meyering
On Sun, Oct 29, 2017 at 4:27 PM, Paul Eggert wrote: > Jim Meyering wrote: >> >> Here's a proposed patch: > > I prefer 'assume' to 'assure' here, since it's a low-level time-comparison > primitive and lots of other code in the module already silently assumes that > the

Re: latest gcc vs lib/timespec.h:85

2017-10-29 Thread Paul Eggert
Jim Meyering wrote: Here's a proposed patch: I prefer 'assume' to 'assure' here, since it's a low-level time-comparison primitive and lots of other code in the module already silently assumes that the timestamps are valid. Also, while I was in the neighborhood I noticed that the cast is no

[PATCH] Port recent gnulib-tool change to Dash

2017-10-29 Thread Paul Eggert
* gnulib-tool (func_create_testdir): Don't assume that the shell retokenizes after expanding "$@" inside the call to func_execute_command. Dash 0.5.8-2.1ubuntu2 does not. --- ChangeLog | 7 +++ gnulib-tool | 8 ++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git

Re: latest gcc vs lib/timespec.h:85

2017-10-29 Thread Jim Meyering
On Fri, Oct 27, 2017 at 9:33 PM, Jim Meyering wrote: > On Mon, Oct 2, 2017 at 6:31 PM, Paul Eggert wrote: >> On 10/02/2017 06:24 PM, Jim Meyering wrote: >>> >>> Given all of the comments on that function, I'd be tempted to suppress >>> this warning in that

Re: test failures on Haiku

2017-10-29 Thread Bruno Haible
The attached patches fix some of these failures. The remaining failures are: > FAIL: test-areadlinkat > == > > ../../gltests/test-areadlinkat.c:78: assertion 'errno == EBADF' failed > Abort > FAIL test-areadlinkat (exit status: 134) > > FAIL: test-cloexec >

Re: gnulib Compressed HTML help

2017-10-29 Thread Gisle Vanem
Bruno Haible wrote: The answer is: When I use it with kchmviewer, it provides fast scrolling through the (huge) TOC, a search index, and a fast search facility. Which is not built-in into browsers and is often emulated with slow JavaScript. Agreed. It is also viewable in 'okular', but it

gnulib-tool: avoid unnecessary config.h remaking in testdirs

2017-10-29 Thread Bruno Haible
Just saw this after creating a testdir: $ cd testdir1 $ ./configure $ make (CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/bash /media/develdata/devel/GNULIB/gnulib-git/testdir1/build-aux/missing autoheader) rm -f stamp-h1 touch config.h.in cd . && /bin/bash ./config.status config.h config.status:

Re: link error with libgcrypt

2017-10-29 Thread Bruno Haible
Hi Jia, > I will still have a link failure with crypto/gc-sm3 and even > crypto/gc. > > In order to reproduce this link failure, I need to have a latest > libgcrypt installed, and then configure gnulib in this way: > > $ ./gnulib-tool --create-testdir --dir=testdir --single-configure >

gnulib Compressed HTML help

2017-10-29 Thread Gisle Vanem
Maybe a bit off-topic, but I've created a Compressed HTML-file from the doc/*.texi files. Using this makefile snippet: TEXI2HTML ?= py -3 f:/ProgramFiler/Python36/Tools/scripts/texi2html.py gnulib.chm: gnulib.texi -mkdir output $(TEXI2HTML) -H gnulib $< output hhc gnulib.hhp

Re: [PATCH] sm3: support to compile with libgcrypt

2017-10-29 Thread Jia Zhang
于 2017/10/29 下午4:24, Bruno Haible 写道: > Hi Jia, > >> I refreshed the patches based on the latest master branch. > > Thanks. > >> Basically the problem we discussed may still exist. > > Yes it still exists. The testdir for 'crypto/gc-sm3' fails to compile for me, > whereas 'crypto/gc-sha1'

crypto/*: verify that the header file is self-contained

2017-10-29 Thread Bruno Haible
This patch verifies that the header files don't accidentally require or . 2017-10-29 Bruno Haible crypto/*: Verify that the header file is self-contained. * tests/test-gc-*.c: Include the module's header file immediately after . *

Re: [PATCH] sm3: support to compile with libgcrypt

2017-10-29 Thread Bruno Haible
Hi Jia, > I refreshed the patches based on the latest master branch. Thanks. > Basically the problem we discussed may still exist. Yes it still exists. The testdir for 'crypto/gc-sm3' fails to compile for me, whereas 'crypto/gc-sha1' works. The following fixes it for me: diff --git

Re: [V3 PATCH] Implement SM3 hash algorithm in gnulib

2017-10-29 Thread Bruno Haible
Hi Jia, > I don't have this issue. Maybe /usr/include/gcrypt.h doesn't exist in > your environment? Correct, I don't have /usr/include/gcrypt.h in my environment. > Also, could you try to compile crypto/gc and see whether it has the > same failure? The testdir for module crypto/gc works fine

test failures on Haiku

2017-10-29 Thread Bruno Haible
On a recent Haiku (32-bit system), a POSIX testdir shows 44 failures: FAIL: test-areadlinkat == ../../gltests/test-areadlinkat.c:78: assertion 'errno == EBADF' failed Abort FAIL test-areadlinkat (exit status: 134) FAIL: test-cloexec ==

random, random_r: update doc regarding Haiku

2017-10-29 Thread Bruno Haible
In a testdir on Haiku, I'm seeing these warnings: In file included from ../../gltests/test-random.c:21:0: ../../gltests/test-random.c:25:18: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types] SIGNATURE_CHECK (random, long, (void)); ^

Re: [PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-29 Thread Assaf Gordon
Hello, On 2017-10-24 04:09 AM, Bruno Haible wrote: Indeed, we don't have many crypto experts on the gnulib mailing lists. Therefore, I too would like the crypto experts on the libgcrypt or openssl mailing lists to evaluate the SM3 algorithm and your code first, before we can accept it in