error: Support the compiler's control flow analysis better (was: copy-file: Silence gcc warnings)

2023-05-27 Thread Bruno Haible
Paul Eggert wrote: > > Maybe by defining > > error and error_at_line as inline functions > > They're defined by glibc, no? The definitions might collide. Yes, they are defined in glibc. Overriding functions without causing collisions is our core expertise here :) > Also, I suppose the compiler

Re: diffseq: Silence gcc warning

2023-05-27 Thread Paul Eggert
On 2023-05-27 09:25, Bruno Haible wrote: For 30 years, "gcc -Wall" has been and is the best recipe for getting meaningful warnings across packages. It's not like a "random compiler". It can be a random compiler if you use GCC the wrong way. If you use an old version of GCC it might generate

Re: diffseq: Silence gcc warning

2023-05-27 Thread Bruno Haible
Paul Eggert wrote: > >$ ../configure CC=gcc CXX=g++ CPPFLAGS=-Wall 2>&1 | tee log1 > > Oh, that enables warnings (i.e., it looks for lint), but it is not > compiling with -DGCC_LINT. It enables warnings, because in my experience '-Wall' is a good recipe across packages (except for

Re: diffseq: Silence gcc warning

2023-05-27 Thread Paul Eggert
On 2023-05-27 02:39, Bruno Haible wrote: $ ../configure CC=gcc CXX=g++ CPPFLAGS=-Wall 2>&1 | tee log1 Oh, that enables warnings (i.e., it looks for lint), but it is not compiling with -DGCC_LINT. In general we don't need to support that combination, any more than we need to support lint

Re: diffseq: Silence gcc warning

2023-05-27 Thread Bruno Haible
Paul Eggert wrote: > > diffseq.h:424:36: warning: 'fxbest' may be used uninitialized > > [-Wmaybe-uninitialized] > > diffseq.h:431:36: warning: 'bxbest' may be used uninitialized > > [-Wmaybe-uninitialized] > > What platform are you using and how did you configure and build? To reproduce with