On 16/10/16 16:01, Bruno Haible wrote:
> Hi,
>
> When I compile a gnulib testdir with "gcc -Wall", I see the following warnings
> (among others):
>
> test-ffsl.c: In function 'main':
> test-ffsl.c:44:12: warning: unused variable 'x' [-Wunused-variable]
>
> test-posix_spawn3.c: In function 'paren
On 16/10/16 15:09, Bruno Haible wrote:
> Hi,
>
> In the configure output of a full gnulib testdir, we have thousands of
> "checking ..." messages but also 2 times "configure: checking ..."
>
> ...
> checking whether fflush works on input streams... (cached) no
> checking for _fseeki64... no
> che
On 16/10/16 17:49, Bruno Haible wrote:
> Hi Pádraig,
>
> On a glibc system (glibc 2.15, Linux 3.8) I get these test failures
> from a gnulib testdir:
>
> 1) For module 'quotearg':
>
> FAIL: test-quotearg.sh
>
> $ LOCALE=fr_FR.UTF-8 LOCALEDIR=locale ./test-quotearg
> test-quotearg.h:53: assertio
On 16/10/16 19:10, Bruno Haible wrote:
> On a glibc system (glibc 2.15, Linux 3.8) I get this test failure
> from a gnulib testdir:
>
> ./../build-aux/test-driver: line 107: 6269 Segmentation fault "$@" >
> $log_file 2>&1
> FAIL: test-duplocale
>
> FAIL test-duplocale (exit status: 139)
>
On 06/10/16 12:53, Pádraig Brady wrote:
> On 06/10/16 11:11, john woods wrote:
>> date +%YW%V gives week and year; it would be nice if date +%YQ%q could
>> return, eg 2016Q3 as having a quarters code in date would save AWKwardness
>> or shell arithmetic.
>>
>> Pe
unarchive 23153
stop
On 05/04/16 15:49, Rishabh Dave wrote:
> Did fix that - changing function call to GNU style and "suffix_from_env" to
> local variable. The corresponding patch is attached.
>
> On Mon, Apr 4, 2016 at 10:36 PM, Paul Eggert wrote:
>
>> On 04/04/2016 09:30 AM, Rishabh Dave wrot
On 02/11/16 15:25, Pádraig Brady wrote:
> On 06/10/16 12:53, Pádraig Brady wrote:
>> On 06/10/16 11:11, john woods wrote:
>>> date +%YW%V gives week and year; it would be nice if date +%YQ%q could
>>> return, eg 2016Q3 as having a quarters code in date would sa
On 22/10/16 18:25, Bruno Haible wrote:
> Hi Jim,
>
>>> 2016-10-16 Bruno Haible
>>>
>>> gnulib-tool: Make --create-testdir on all modules work again.
>>> * gnulib-tool (func_create_testdir): Don't include the
>>> non-recursive-gnulib-prefix-hack module.
>> That looks fine
On 05/11/16 18:00, Pádraig Brady wrote:
> On 22/10/16 18:25, Bruno Haible wrote:
>> Hi Jim,
>>
>>>> 2016-10-16 Bruno Haible
>>>>
>>>> gnulib-tool: Make --create-testdir on all modules work again.
>>>> * gnulib
On 07/11/16 02:35, Bruno Haible wrote:
> Hi Pádraig,
>
>>> lib/gnulib.mk:32: error: required file '$gl_source_base/alloca.c' not found
>>> Makefile.am:226: 'lib/local.mk' included from here
>>> lib/local.mk:1: 'lib/gnulib.mk' included from here
>>> autoreconf: automake failed with exit status:
On 09/11/16 11:21, Frediano Ziglio wrote:
> The small code in m4/manywarnings.m4 wrongly detects if
> -Wno-missing-field-initializers is needed. This happens if
> -Wunused-variable is set. In this case the code fails to compile
> due to -Werror even if -Wno-missing-field-initializers would be
> per
On 14/11/16 19:51, Eric Blake wrote:
> [adding gnulib]
>
> On 11/14/2016 04:23 AM, Daniel P. Berrange wrote:
>> On Sat, Nov 12, 2016 at 02:58:03PM -0600, Eric Blake wrote:
>>> In particular, pull in gnulib's fix for the broken SIZE_MAX on s390.
>
>>>
>>> * .gnulib e89b4a7...5ddd9d7 (73):
>>> >
On 14/11/16 21:10, Bruno Haible wrote:
> Hi Pádraig,
>
>> add to strptime()
>> also for consistency. Therefore I did that in the attached,
>> added a test, and pushed.
>
> If users of the 'strptime' module should be able to rely on the %q feature,
> it requires also a change in doc/posix-functio
With this we can use this check in coreutils to find configure issues:
grep -E '(program exited with status 1$|core dumped)' config.log
* m4/mbrtowc.m4 (gl_MBRTOWC_C_LOCALE): Don't return 1
from the test program as this often indicates an
unhandled case in the test program.
(gl_MBRTOWC_INCOMPLET
On 26/11/16 23:49, Paul Eggert wrote:
> On 11/25/2016 06:00 PM, Paul Eggert wrote:
>> Isn't that a bug in glibc freopen? It shouldn't fail ... merely
>> because stdin doesn't have a valid file descriptor. If so, we should
>> fix the Gnulib freopen module to work around the bug.
>
> I did that, b
Pushed.
thanks
On 01/12/16 10:52, KO Myung-Hun wrote:
> Hi/2.
>
> These are OS/2 patches.
>
> Review, please...
>
> [PATCH 1/4] sys_socket: typedef sa_family_t correctly on OS/2 kLIBC
> [PATCH 2/4] relocatable: Fix that /@unixroot prefix is not working on
> [PATCH 3/4] alphasort, scandir: Port to OS/2 kLIBC
>
On 13/12/16 17:43, John W. Eaton wrote:
> The test in link.m4 needs to include to provide a declaration
> for the rename function. The test fails if building with GCC's
> -Werror=implicit-function-declaration option.
>
> This was reported as part of a bug with building Octave on Fedora, which
On 17/12/16 11:08, Bruno Haible wrote:
> I'm seeing this compilation failure on a recent mingw:
looks good to me.
thanks
On 21/12/16 23:55, Bruno Haible wrote:
> Hi Pavel,
>
>> But I'm rather asking whether we know about recent issues.
>>
>> Firstly I noticed the hang on ppc64le, but later it occurred on x86_64, ppc64
>> and i686: https://koji.fedoraproject.org/koji/taskinfo?taskID=16970779
>> so this is not arch-sp
On 22/12/16 00:06, Bruno Haible wrote:
> Has anyone reproduced a test-lock crash due to broken weak symbol support
> in binutils or gcc in the last two years?
>
> Just to make sure there's no TODO item left for [1], [2], [3].
>
> Bruno
>
> [1] https://lists.gnu.org/archive/html/bug-gnulib/2013-1
On 22/12/16 21:58, Bruno Haible wrote:
> Pádraig Brady wrote:
>> There was a recent enough report on helgrind reporting issues with it:
>> https://lists.gnu.org/archive/html/bug-gnulib/2015-07/msg00032.html
>
> I would view this as a false positive. The test uses some
On 24/12/16 17:52, Bruno Haible wrote:
> Hi Pádraig,
>
>> Wow that's much better on a 40 core system:
>>
>> Before your patch:
>> =
>> $ time ./test-lock
>> Starting test_lock ... OK
>> Starting test_rwlock ... OK
>> Starting test_recursive_lock ... OK
>> Starting test_once ... OK
On 02/01/17 02:25, Assaf Gordon wrote:
> Hello,
>
> Attached are four small bug fixes and two additions to the debug messages in
> parse-datetime.y (used in 'date --debug').
> The commit message for each commit gives a detail example of how/when it is
> used.
> There are no changes to the parsin
/ChangeLog
index 66ea430..b2fe194 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2017-01-02 Pádraig Brady
+
+ maint.mk: support parallel execution of coverage
+ * top/maint.mk (coverage): Run dependencies serially,
+ thus supporting parallel processing of each one
On 26/07/15 15:41, Rakesh Kumar wrote:
> Hi All,
>
> While trying to generate HTML test coverage reports, I am facing an
> error. Can anyone please advice on this. Help would be appreciated.
>
>
> [00:36 rakesh@param
> /home/rakesh/development/gnu_development/coreutils$] :
> lcov -t coreutils -
On 03/01/17 01:25, Pádraig Brady wrote:
> On 26/07/15 15:41, Rakesh Kumar wrote:
>> Hi All,
>>
>> While trying to generate HTML test coverage reports, I am facing an
>> error. Can anyone please advice on this. Help would be appreciated.
>>
>>
>> [0
On 04/01/17 10:54, Bruno Haible wrote:
> Hi Pavel,
>
>> Can we assume all systems supporting pthreads are conforming to this
>> specs? That was pretty big (and pretty recent) change of specification.
>
> The change in the specification [4] mentions that the issue arose with glibc,
> and it point
On 17/01/17 01:13, J William Piggott wrote:
>
> Hello all, I am not subscribed so please cc me.
>
>>From my local gnulib git repo when I run:
> ./gnulib-tool --create-testdir --dir=/tmp/test3 parse-datetime
>
> It fails with:
> /bin/sh ../build-aux/ylwrap ./parse-datetime.y \
>
* lib/parse-datetime.y (parse_datetime2): Use consistent spacing,
remove redundant line continuation characters,
remove redundant if (pc.parse_datetime_debug) checks.
Avoid a redundant call to get_effective_timezone() when not debugging.
---
lib/parse-datetime.y | 99 +-
FYI when compiling coreutils on centos 5 (gcc-4.1.2) I noticed:
any use of INT_MULTIPLY_WRAPV gave the warning:
src/pr.c:1274: warning: comparison is always false due to limited range of
data type
On 19/02/17 10:47, Bruno Haible wrote:
> Hi,
>
> In many installations, clang has strange/odd/buggy library search paths. In
> particular, on the Ubuntu binaries from http://releases.llvm.org/download.html
> search in /lib64/ although this directory contains no libraries (only the
> ld.so).
> Thi
On 28/11/16 06:34, Oliver Heimlich wrote:
> Follow-Up: Savannah bugs #48534 #48535.
>
> Hi,
> I have two problems with the function num_processors in libgnu's nproc.c.
>
>
> FIRST PROBLEM
>
> num_processors (NPROC_CURRENT_OVERRIDABLE) returns the value of
> OMP_NUM_THREADS. However, if a thread
On 20/02/17 20:59, Pádraig Brady wrote:
> On 28/11/16 06:34, Oliver Heimlich wrote:
>> Follow-Up: Savannah bugs #48534 #48535.
>>
>> Hi,
>> I have two problems with the function num_processors in libgnu's nproc.c.
>>
>>
>> FIRST PROBLEM
>>
&
On 26/02/17 09:05, Bruno Haible wrote:
> Hi Pádraig,
>
> The function 'num_processors' is now a bit large, and in particular contains
> the multiplied complexity of
> - the number of systems which each require a different approach,
> - the query parameter which in one MUST consider omp_env_lim
-> gnulib
Forwarded Message
Subject: Re: new snapshot available: coreutils-8.26.57-00381
Date: Thu, 2 Mar 2017 23:59:37 -0500
From: Assaf Gordon
To: Pádraig Brady
CC: Coreutils
Hello Pádraig and all,
> On Mar 1, 2017, at 22:42, Pádraig Brady wrote:
>
from 2017-01-05).
> Reported by Assaf Gordon via
> Pádraig Brady .
> * tests/test-lock.c: On Mac OS X, use named semaphores, not unnamed
> semaphores.
> (USE_NAMED_SEMAPHORE, USE_UNNAMED_SEMAPHORE): New macros.
> (atomic_int_semaphore): New macro.
* modules/parse-datetime: Remove the tmp generated source.
---
modules/parse-datetime | 1 +
1 file changed, 1 insertion(+)
diff --git a/modules/parse-datetime b/modules/parse-datetime
index 5d10137..1b92db0 100644
--- a/modules/parse-datetime
+++ b/modules/parse-datetime
@@ -40,6 +40,7 @@ parse-
Removes extraneous parse-datetime.c generated during build
---
gnulib | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnulib b/gnulib
index d318147..405cd67 16
--- a/gnulib
+++ b/gnulib
@@ -1 +1 @@
-Subproject commit d3181471f95c870e9485be947608be84f7fe5325
+Subproject comm
Wow impressive improvements!
On 22/04/17 02:18, Paul Eggert wrote:
> (date): Fix printf of size_t to use %z.
In coreutils we explicitly disallow the C99 %j and %z specifiers
due to portability issues on solaris 8 for example:
http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=v8.23-75-g7d1fe88
On 22/04/17 02:18, Paul Eggert wrote:
> Thanks for the heads-up. That code has long been on my list of things to
> clean
FYI I'm currently running date(1) with this change
+ ASAN enabled, through the latest AFL fuzzer,
seeded with the coreutils test corpus.
| 15 +++
lib/time_rz.c | 15 +--
tests/test-parse-datetime.c | 16
3 files changed, 44 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index fd5ec89..314f7d9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,18 @@
+2017-04-26 Pádr
* tests/nap.h: Move misplaced endif.
---
ChangeLog | 5 +
tests/nap.h | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index 314f7d9..12ccfc1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,4 +1,9 @@
2017-04-26 Pádraig Brady
+
+ nap.h: Fix
On 30/04/17 07:53, Bruno Haible wrote:
> Hi,
>
> The name of the strftime module is misleading:
> 1) It suggests that it defines the function 'strftime', but in fact it
> defines 'nstrftime'. GNU findutils fell into this pit: their
> bootstrap.conf
> requests the gnulib 'strftime' mod
On 26/04/2024 10:48, Bruno Haible wrote:
I committed this patch, which activates the Python rewrite of gnulib-tool
for all users who have Python installed, without the need to set any
environment variable. I'll make announcements to info-gnu and planet.gnu.org
soon.
+if (python3 --version)
On 27/04/2024 14:32, Bruno Haible wrote:
Hi Pádraig,
+if (python3 --version) >/dev/null 2>/dev/null \
+ && case `python3 --version 2>&1` in
+Python\ 3.[0-6] | Python\ 3.[0-6].*) false ;;
+Python\ 3.*) true ;;
+*) false ;;
+ esac; then
It
On 13/05/2024 21:48, Collin Funk wrote:
Hi Paul,
On 5/13/24 9:39 AM, Paul Eggert wrote:
I realized that I invoked ' ./gnulib-tool --create-testdir --dir foo stdbit'
with the wrong options so I interrupted it with control-C. It then gave me the
following long traceback, which is not useful. I
On 11/06/2024 19:54, Bruno Haible wrote:
I'm debugging a unit test that consists of a dozen of shell statement groups,
each with a 'returns_ 1 ...' invocation. The log file shows an error message,
but no indication from which of the statement groups the error came. So,
naturally, I add a 'set -x'
On 04/08/2024 17:23, Bernhard Voelker wrote:
-LC_ALL=C returns_ 0 ${CHECKER} test-dfa-match-aux 'x+x+x+' xx > out 2>&1
+LC_ALL=C ${CHECKER} test-dfa-match-aux 'x+x+x+' xx > out 2>&1 || fail=1
Both look good, please push.
thanks,
Pádraig
On 07/08/2024 18:56, Bruno Haible wrote:
On 2024-07-07, I stated:
This provides enough justification for gnulib to override the glibc behaviour
here. I will therefore go ahead and override
PTHREAD_RWLOCK_INITIALIZER
pthread_rwlock_init
pthread_rwlock_attr_init
to use PREFER_WRITER or PR
On 09/08/2024 11:03, Bruno Haible wrote:
Pádraig Brady wrote:
FYI coreutils CI started failing with this on cfarm13.cfarm.net (debian 11.9)
with:
FAIL: test-pthread-rwlock-waitqueue
===
test-pthread-rwlock-waitqueue.c:234: assertion 'startswith (do_test (&
On 15/08/2024 02:05, Paul Eggert wrote:
delete mode 100644 lib/verror.c
From coreutils CI:
make[3]: *** No rule to make target '../lib/verror.c', needed by
'coreutils.pot-update'.
thanks,
Pádraig
On 15/08/2024 23:13, Paul Eggert wrote:
Thanks, I installed the attached.
Oh it required a change in downstream projects.
I assumed it was gnulib specific.
Thanks for fixing it in coreutils.
Pádraig
On 24/08/2024 17:49, Bruno Haible wrote:
In most Gnulib modules, when we have a function that does something
and another function that does the same thing with diagnostics, the
common convention is that the latter has an 'x' prefix. Such as for
malloc — xalloc
vasprintf — xvasprintf
getc
On 25/08/2024 11:48, Bruno Haible wrote:
Pádraig Brady wrote:
I always thought the x...() variants indicate they might eXit().
Are there any other x...() variants that just output a diagnostic,
and don't exit()?
Indeed, we currently have three categories of x...() variants:
- Mo
--git a/ChangeLog b/ChangeLog
index 8a7f812b67..fdcc79134e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2024-08-28 Pádraig Brady
+
+ avoid GCC -Wmaybe-uninitialized false positives with LTO
+ Avoids false warnings with GCC 14.2.1 with -flto
+
+ * lib/canonicalize.c: Initialize
801 - 856 of 856 matches
Mail list logo
