maint.mk sc_copyright_check won't handle multiple lines

2013-03-08 Thread Martin von Gagern
ever come out of this? Doesn't look that way to me, but I don't closely follow the list. Greetings, Martin von Gagern signature.asc Description: OpenPGP digital signature

Syntax checks in perl (was: Re: maint.mk syntax check problems)

2011-09-15 Thread Martin von Gagern
On 15.09.2011 11:37, Jim Meyering wrote: I'm sure that a perl-based implementation would be far more efficient, and probably faster even if the perl implementation doesn't run its tests in parallel. Perl is well suited to this task. I'm sure some will object to Perl's syntax, but not I.

Re: Syntax checks in perl

2011-09-15 Thread Martin von Gagern
Hi Stefano. On 15.09.2011 21:08, Stefano Lattarini wrote: Perl versions from 5.8 onwards should have a threading interface too, if I'm not mistaken. I don't know how powerful or easy-to-use it is, though. Afaik ithreads support is an optional feature, not sure how distros out there handle

Re: maint.mk syntax check problems

2011-09-14 Thread Martin von Gagern
Hi Bruno, thanks for your reply! On 05.09.2011 21:45, Bruno Haible wrote: I don't think it makes sense to run such stylistic checks on files that are not under your control. po/Makefile.in.in is owned by the gettext maintainer, and the *.po files are in the hands of the translators. In other

Re: maint.mk syntax check problems

2011-09-14 Thread Martin von Gagern
interested in some feedback what you think about turning those syntax checks into a shell script file instead of embedding so much ugly backslash-continued shell code into the makefile. Hoping for some more reaction, Martin von Gagern On 05.09.2011 14:16, Martin von Gagern wrote: Hi! I'm currently

Re: maint.mk syntax check problems

2011-09-14 Thread Martin von Gagern
Thanks, Jim, for the swift reply this time! On 14.09.2011 14:49, Jim Meyering wrote: 1. main.mk fails its own checks: The checks sc_makefile_at_at_check and sc_prohibit_undesirable_word_seq both fail for me, as the maint.mk file itself violates these checks. I know, this will probably only

Re: maint.mk syntax check problems

2011-09-14 Thread Martin von Gagern
Re-sending for the mailing list, forgot that a moment ago. On 14.09.2011 16:49, Simon Josefsson wrote: I'm not a fan of separate shell scripts, each new file to deal with seems to incur a small maintainance cost over time -- consider when they are renamed or moved. I think gnulib already

maint.mk syntax check problems

2011-09-05 Thread Martin von Gagern
to that effect: http://bzr.savannah.gnu.org/lh/wdiff/trunk/revision/66 as discussed in http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/20443/focus=20454 Greetings, Martin von Gagern signature.asc Description: OpenPGP digital signature

gettext 0.17 legacy

2010-05-25 Thread Martin von Gagern
Hi there! Commit 190bf61ecbb3727a3dd742498938be9e251f9315 on 2010-05-09 updated gettext from 0.17 to 0.18, but left the file build-aux/po/Makefile.in.in in its old form from gettext-0.17. This will cause problems for packages that use separate po files for gnulib. Greetings, Martin von Gagern

maint.mk sc_prohibit_always_true_header_tests: bad cd

2010-05-25 Thread Martin von Gagern
Hi there! Running make sc_prohibit_always_true_header_tests causes a cd invocation to fail, without make aborting: prohibit_always_true_header_tests /bin/sh: line 0: cd: ./gnulib/lib: No such file or directory It would be nice to actually check that $(gnulib_dir) exists, and either skip the

maint.mk sc_prohibit_always-defined_macros complains about build-aux/warn-on-use.h

2010-05-25 Thread Martin von Gagern
... Greetings, Martin von Gagern signature.asc Description: OpenPGP digital signature

Re: [wdiff-bugs] wdiff-0.6.1 build problems

2010-04-03 Thread Martin von Gagern
solves the issue? I've asked Nelson for additional information, config.{log,status} in particular, so maybe we can provide more details soon. Greetings, Martin von Gagern signature.asc Description: OpenPGP digital signature

Re: maintainer-makefile troubles and suggestions

2010-02-03 Thread Martin von Gagern
On 31.01.2010 19:11, Bruno Haible wrote: There is the possibility to use approach 3, by - using the gnulib-tool options --po-base and --po-domain, - defining the DEFAULT_TEXT_DOMAIN macro in lib/Makefile.am. The PO files for gnulib will be automatically downloaded from the Translation

Improvements for maint.mk

2010-01-21 Thread Martin von Gagern
commit my modifications to the wdiff tree in order to make them officially owned by the FSF? Greetings, Martin von Gagern

[PATCH 1/4] vc-list-files: List bzr files recursively.

2010-01-21 Thread Martin von Gagern
bzr ls isn't recursive by default, so we have to add the --recursive flag. The short form would have been -R, but as the script uses --versioned instead of -V, using the long option seems more consistent. --- build-aux/vc-list-files |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

[PATCH 2/4] maint.mk: cache VC_LIST output.

2010-01-21 Thread Martin von Gagern
Several syntax checks work on the list of all versioned files. Regenerating this list for every such check can be quite time-consuming. To avoid this, a wrapper target could generate this list once, perform all checks, and clean up the list afterwards. As an added benefit, this allows us to

[PATCH 3/4] maint.mk: Update translations using rsync instead of wget.

2010-01-21 Thread Martin von Gagern
Checksums (-c) are used instead of timestamps (-t) to check whether a file is already up to date. This allows integration with version control systems that usually don't preserve timestamps. The listing of files was changed from verbose (-v) to itemize (-i) so it becomes easier to distinguish

[PATCH 4/4] maint.mk: Imporved LINGUAS generation.

2010-01-21 Thread Martin von Gagern
This change avoids duplicates for e...@boldquot and e...@quot. It also ensures that the list is completely sorted and that any comment lines preceding the list of linguas will be preserved. Non-lingua lines following the list of linguas will be moved in front of the linguas, so it is suggested

Re: [PATCH 4/4] maint.mk: Imporved LINGUAS generation.

2010-01-21 Thread Martin von Gagern
On 21.01.2010 15:39, Martin von Gagern wrote: + sed -ie '/^[a-z]/d' $(PODIR)/LINGUAS ^^^ That should have been -i -e instead, as the -i option to sed takes an optional argument. Sorry. I've incorporated my changes into wdiff by now: http://bzr.savannah.gnu.org/lh/wdiff/trunk

Re: maintainer-makefile troubles and suggestions

2010-01-21 Thread Martin von Gagern
Hi Eric! On 21.01.2010 17:10, Eric Blake wrote: Thanks for all the feedback! I've got two more. sc_prohibit_atoi_atof: -- The comment claims that [fs]?scanf doesn't provide error feedback. The return value section of my scanf(3) man page says differently: the number of