Re: [PATCH] dfa: addition of new state on demand

2016-11-26 Thread Norihiro Tanaka
Thanks for the review. I confirmed your changes, and I found no problem. > CC'ing this to grep-devel since that's where the hardy band of dfa > consumers hang out. I will also do it in next post for dfa.

Re: [PATCH] dfa: addition of new state on demand

2016-11-25 Thread Paul Eggert
Jim Meyering wrote: I see one typo in your 2nd change's log: s/cdalls/calls/ Omit unnecessary cdalls to zeroset. Thanks, I fixed that.

Re: [PATCH] dfa: addition of new state on demand

2016-11-25 Thread Jim Meyering
On Fri, Nov 25, 2016 at 11:03 AM, Paul Eggert wrote: > Norihiro Tanaka wrote: >> >> Can anyone review this change? > > > Thanks for doing all that, and sorry about the late review. I reviewed it, > tweaked its commit message and propagated that into ChangeLog (the gnulib >

Re: [PATCH] dfa: addition of new state on demand

2016-11-25 Thread Paul Eggert
Norihiro Tanaka wrote: Can anyone review this change? Thanks for doing all that, and sorry about the late review. I reviewed it, tweaked its commit message and propagated that into ChangeLog (the gnulib practice), and installed the result into gnulib, with two followup patches that I hope

Re: [PATCH] dfa: addition of new state on demand

2016-11-21 Thread Norihiro Tanaka
2016 > > x86_64 x86_64 x86_64 GNU/Linux > > Hi, > > I updated comments in previous patch. > > Thanks, > Norihiro Can anyone review this change? From a2144547298fe31a93e6a65b2c4e7e2037c53980 Mon Sep 17 00:00:00 2001 From: Norihiro Tanaka <nori...@kcn.ne.jp> Date: Mon, 17 Oct 2016 11:27:47 +0900 Sub

Re: [PATCH] dfa: addition of new state on demand

2016-10-17 Thread Norihiro Tanaka
x rhel6 2.6.32-642.el6.x86_64 #1 SMP Wed Apr 13 00:51:26 EDT 2016 x86_64 > x86_64 x86_64 GNU/Linux Hi, I updated comments in previous patch. Thanks, Norihiro From a2144547298fe31a93e6a65b2c4e7e2037c53980 Mon Sep 17 00:00:00 2001 From: Norihiro Tanaka <nori...@kcn.ne.jp> Date: Mon, 17 Oct 2016

[PATCH] dfa: addition of new state on demand

2016-10-16 Thread Norihiro Tanaka
t;nori...@kcn.ne.jp> Date: Mon, 17 Oct 2016 11:27:47 +0900 Subject: [PATCH] dfa: addition of new state on demand * src/dfa.c (dfastate): Add argument UC. It is current input character. fill only a group including the character in transition table. (realloc_trans_if_necessary): Add the dummy state wh