On 1/20/21 3:27 AM, Adhemerval Zanella wrote:
#if defined __STDC_VERSION__ && 201710L < __STDC_VERSION__
# define __attribute_fallthrough__ [[__fallthrough__]]
#elif __GNUC_PREREQ (7, 0) || __glibc_has_attribute (__fallthrough__)
# define __attribute_fallthrough__ __attribute__
Right, this did not showed up on build-many-glibc.py. My plan is to touch
as little code as possible since we are in slush freeze and sync again with
gnulib once we set development for 2.34.
I will fix this as well.
On 20/01/2021 12:32, Vaseeharan Vinayagamoorthy wrote:
> Thanks for the fix,
Thanks for the fix, Adhemerval Zanella.
I assume you would fix this in other files too, for example I think a similar
patch is needed for posix/fnmatch.c.
fnmatch.c:67:26: error: "__clang_major__" is not defined [-Werror=undef]
# if (__GNUC__ >= 7) || (__clang_major__ >= 10)
On 19/01/2021 23:55, Paul Eggert wrote:
> On 1/19/21 7:43 AM, Bruno Haible wrote:
>> Adhemerval Zanella wrote:
>>> -# if (__GNUC__ >= 7) || (__clang_major__ >= 10)
>>> +# if (__GNUC__ >= 7) || (defined __clang_major__ &&__clang_major__ >= 10)
>> I would write it as:
>>
>> +# if (__GNUC__ >= 7)
On 1/19/21 7:43 AM, Bruno Haible wrote:
Adhemerval Zanella wrote:
-# if (__GNUC__ >= 7) || (__clang_major__ >= 10)
+# if (__GNUC__ >= 7) || (defined __clang_major__ &&__clang_major__ >= 10)
I would write it as:
+# if (__GNUC__ >= 7) || (defined __clang__ && __clang_major__ >= 10)
This line
On 19/01/2021 14:16, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> On 19/01/2021 13:52, Florian Weimer wrote:
>>> * Adhemerval Zanella via Libc-alpha:
>>>
Paul, this seemed to a common pattern scatter on multiple file in gnulib.
Wouldn't be better to consolidate it on cdefs.h?
* Adhemerval Zanella:
> On 19/01/2021 13:52, Florian Weimer wrote:
>> * Adhemerval Zanella via Libc-alpha:
>>
>>> Paul, this seemed to a common pattern scatter on multiple file in gnulib.
>>> Wouldn't be better to consolidate it on cdefs.h?
>>
>> gnulib shouldn't be using cdefs.h on glibc
On 19/01/2021 13:52, Florian Weimer wrote:
> * Adhemerval Zanella via Libc-alpha:
>
>> Paul, this seemed to a common pattern scatter on multiple file in gnulib.
>> Wouldn't be better to consolidate it on cdefs.h?
>
> gnulib shouldn't be using cdefs.h on glibc systems, so I think a
> separate
* Adhemerval Zanella via Libc-alpha:
> Paul, this seemed to a common pattern scatter on multiple file in gnulib.
> Wouldn't be better to consolidate it on cdefs.h?
gnulib shouldn't be using cdefs.h on glibc systems, so I think a
separate header would be needed.
Thanks,
Florian
--
Red Hat GmbH,
Adhemerval Zanella wrote:
> -# if (__GNUC__ >= 7) || (__clang_major__ >= 10)
> +# if (__GNUC__ >= 7) || (defined __clang_major__ &&__clang_major__ >= 10)
I would write it as:
+# if (__GNUC__ >= 7) || (defined __clang__ && __clang_major__ >= 10)
because 'defined __clang__' is the widely known
After this commit [1], I am seeing -Werror=undef when bootstapping glibc on
aarch64-none-linux-gnu :
In file included from regex.c:70:0:
regex_internal.h:852:26: error: "__clang_major__" is not defined [-Werror=undef]
# if (__GNUC__ >= 7) || (__clang_major__ >= 10)
On 19/01/2021 11:16, Vaseeharan Vinayagamoorthy wrote:
> After this commit [1], I am seeing -Werror=undef when bootstapping glibc on
> aarch64-none-linux-gnu :
>
> In file included from regex.c:70:0:
> regex_internal.h:852:26: error: "__clang_major__" is not defined
> [-Werror=undef]
> #
This patch looks good to me, thanks.
It sync with gnulib commit 43ee1a6bf. The main change is 9682f18e9.
(which does not have a meaniful description).
Checked on x86_64-linux-gnu.
---
posix/regcomp.c| 2 +-
posix/regex.h | 17 -
posix/regex_internal.c | 19 ++-
14 matches
Mail list logo
