On Sun, Dec 02, 2018 at 01:31:03PM +0100, Bruno Haible wrote:
> Roman Bolshakov wrote:
> > I'm quite new to gnulib but thanks to Eric and your comments that should do
> > it:
> >
> > diff --git a/modules/maintainer-makefile b/modules/maintainer-makefile
> > index 39b51583c..13b8c546a 100644
> >
Roman Bolshakov wrote:
> I'm quite new to gnulib but thanks to Eric and your comments that should do
> it:
>
> diff --git a/modules/maintainer-makefile b/modules/maintainer-makefile
> index 39b51583c..13b8c546a 100644
> --- a/modules/maintainer-makefile
> +++ b/modules/maintainer-makefile
> @@
On Tue, Nov 27, 2018 at 07:47:12PM +0100, Bruno Haible wrote:
> Eric Blake wrote:
> > > In other words, can you guarantee that $(GREP) will never expand to empty?
> >
> > If we change gl_INIT() to AC_REQUIRE([AC_PROG_GREP]), then that should
> > be sufficient to ensure $(GREP) is set by the time
Eric Blake wrote:
> > In other words, can you guarantee that $(GREP) will never expand to empty?
>
> If we change gl_INIT() to AC_REQUIRE([AC_PROG_GREP]), then that should
> be sufficient to ensure $(GREP) is set by the time Makefile is parsed,
> which in turn will propagate to maint.mk.
Yes.
On 11/27/18 12:47 PM, Bruno Haible wrote:
Yes. And (question to Roman): what the proper place to change, so that
gl_INIT() contains AC_REQUIRE([AC_PROG_GREP]) ?
Hint: The answer is contained in this part of the Gnulib documentation:
On 11/27/18 12:21 PM, Bruno Haible wrote:
Roman Bolshakov wrote:
Autoconf can discover an alias for GNU
grep and set it in GREP but it takes no effect for maint.mk
Does Automake always invoke this Autoconf macro which sets GREP?
In other words, can you guarantee that $(GREP) will never
Roman Bolshakov wrote:
> Autoconf can discover an alias for GNU
> grep and set it in GREP but it takes no effect for maint.mk
Does Automake always invoke this Autoconf macro which sets GREP?
In other words, can you guarantee that $(GREP) will never expand to empty?
Bruno
A project that uses maint.mk can specify regular expressions that are
not supported in system grep. Autoconf can discover an alias for GNU
grep and set it in GREP but it takes no effect for maint.mk
The patch provides an ability to use GNU grep if it was discovered by
autoconf and by calling GNU
