The latest patch looks reasonable to me. Bruno, you're the minmax
maintainer: can you please take a look at it?
___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib
Paul Eggert wrote:
>Derek Price <[EMAIL PROTECTED]> writes:
>
>
>
>>Corrected patch attached.
>>
>>
>
>Thanks. A couple more things. (Sorry I didn't catch it earlier.)
>First, the $gl_* variables should be cached, with AC_CACHE_CHECK.
>
>
Done.
>Second, suppose and have conflicting
>
Derek Price <[EMAIL PROTECTED]> writes:
> Corrected patch attached.
Thanks. A couple more things. (Sorry I didn't catch it earlier.)
First, the $gl_* variables should be cached, with AC_CACHE_CHECK.
Second, suppose and have conflicting
definitions of MIN and MAX? To work around the latter po
Paul Eggert wrote:
>Derek Price <[EMAIL PROTECTED]> writes:
>
>
>
>
>>+#ifdef LIMITS_H_HAS_MINMAX
>>+# include
>>+#elif SYS_PARAM_H_HAS_MINMAX
>>+# include
>>+#endif
>>
>>
>
>This doesn't work if and both define MIN.
>
>
Hrm. Okay, I've fixed this, though I think such a system that i
Derek Price <[EMAIL PROTECTED]> writes:
> +#ifdef LIMITS_H_HAS_MINMAX
> +# include
> +#elif SYS_PARAM_H_HAS_MINMAX
> +# include
> +#endif
This doesn't work if and both define MIN.
> + AC_CHECK_HEADERS_ONCE([sys/param.h],
> +[gl_have_sys_param_h=:], [gl_have_sys_param_h=false])dnl
You
Paul Eggert wrote:
>Derek Price <[EMAIL PROTECTED]> writes:
>
>
>
>>minmax was so nice and small, but would you be willing to add an m4 file
>>which called AC_CHECK_HEADERS([sys/param.h]) and the following lines to
>>the beginning of minmax.h?
>>
>>#ifdef HAVE_SYS_PARAM_H
>># include
>>#endif
>
Derek Price <[EMAIL PROTECTED]> writes:
> minmax was so nice and small, but would you be willing to add an m4 file
> which called AC_CHECK_HEADERS([sys/param.h]) and the following lines to
> the beginning of minmax.h?
>
> #ifdef HAVE_SYS_PARAM_H
> # include
> #endif
Better yet, why not have "con
On Friday, May 13, 2005 at 18:54, Derek Price wrote:
> /usr/include/sys/param.h:222: warning: `MIN' redefined
> /usr/include/sys/param.h:223: warning: `MAX' redefined
[..]
> minmax was so nice and small, but would you be willing to add an m4 file
> which called AC_CHECK_HEADERS([sys/param.h]) and t
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I get the following warning on NetBSD 1.6.1 when using the minmax module:
In file included from /usr/include/arpa/inet.h:65,
from socket-client.h:27,
from socket-client.c:20:
/usr/include/sys/param.h:222: warning: `MI
