Re: [bug-gnulib] Re: Opening a can of worms: a readline gnulib module?

Oskar Liljeblad wrote: > That's why you have xyz_LTLIBS, xyz_CFLAGS etc. One such example is > PTHREAD_CFLAGS, would you prefer that or CFLAGSPTHREADS? I would > prefer the former. HAVE_READLINE vs. READLINE_LIBS is just inconsistent. Either READLINE_PRESENT and READLINE_LIBS. Or HAVE_READLINE and

Re: Opening a can of worms: a readline gnulib module?

Bruno Haible <[EMAIL PROTECTED]> writes: > Simon Josefsson wrote: >> I installed the patch below. It builds on the same platforms, but now >> finds the readline library properly on Fedora too. >> ... >> checking for readline... yes >> checking how to link with libreadline... -lreadline -ltermcap

Re: [bug-gnulib] Re: Opening a can of worms: a readline gnulib module?

On Friday, August 12, 2005 at 13:42, Bruno Haible wrote: > > I'll check the code soon, but why don't you use READLINE_LIBS instead > > of LIBREADLINE etc? That's the convention most other automake macros > > I've seen use. > > But this convention doesn't cope with the fact that link options for li

Re: Opening a can of worms: a readline gnulib module?

Simon Josefsson wrote: > I installed the patch below. It builds on the same platforms, but now > finds the readline library properly on Fedora too. > ... > checking for readline... yes > checking how to link with libreadline... -lreadline -ltermcap This is a problem because libtermcap is unsecure

Re: [bug-gnulib] Re: Opening a can of worms: a readline gnulib module?

Oskar Liljeblad wrote: > I'll check the code soon, but why don't you use READLINE_LIBS instead > of LIBREADLINE etc? That's the convention most other automake macros > I've seen use. But this convention doesn't cope with the fact that link options for libtool may be different than link options for

Re: Opening a can of worms: a readline gnulib module?

Simon Josefsson <[EMAIL PROTECTED]> writes: >> Also check this: >> >> http://ac-archive.sourceforge.net/Installed_Packages/vl_lib_readline.html >> >> It also mentions libedit and libeditline (apparently those are other >> GNU readline-like implementations). > > That seem like a quite useful macro,

Re: Opening a can of worms: a readline gnulib module?

"Oskar Liljeblad" <[EMAIL PROTECTED]> writes: > On Thursday, August 11, 2005 at 23:14, Simon Josefsson wrote: >> >> > I don't know if the readline module covers this, but on recent >> > Fedora/RedHat systems you'll need to link with ncurses or some >> > other library providing certain termcap (or

Re: Opening a can of worms: a readline gnulib module?

On Thursday, August 11, 2005 at 23:14, Simon Josefsson wrote: > > > I don't know if the readline module covers this, but on recent > > Fedora/RedHat systems you'll need to link with ncurses or some > > other library providing certain termcap (or was it terminfo?) > > functions... You don't need to

Re: Opening a can of worms: a readline gnulib module?

"Oskar Liljeblad" <[EMAIL PROTECTED]> writes: > I don't know if the readline module covers this, but on recent > Fedora/RedHat systems you'll need to link with ncurses or some > other library providing certain termcap (or was it terminfo?) > functions... You don't need to do this with Debian. Thi

Re: Opening a can of worms: a readline gnulib module?

Bruno Haible <[EMAIL PROTECTED]> writes: >> > HAVE_READLINE vs. HAVE_READLINE_READLINE_H should be the same. >> >> I solved it slightly differently. I made these two tests orthogonal. >> readline/readline.h is used by the header file if available. >> -lreadline is used instead of the *.c file if

Re: Opening a can of worms: a readline gnulib module?

Simon Josefsson wrote: > Installed the patch below. Thanks a lot. (This stuff is not a piece of cake.) > > HAVE_READLINE vs. HAVE_READLINE_READLINE_H should be the same. > > I solved it slightly differently. I made these two tests orthogonal. > readline/readline.h is used by the header file if a

Re: Opening a can of worms: a readline gnulib module?

I don't know if the readline module covers this, but on recent Fedora/RedHat systems you'll need to link with ncurses or some other library providing certain termcap (or was it terminfo?) functions... You don't need to do this with Debian. Regards, Oskar

Re: Opening a can of worms: a readline gnulib module?

Bruno Haible <[EMAIL PROTECTED]> writes: > Simon Josefsson wrote: >> So the entire M4 file read as below now. Correct? > > gl_cv_lib_readline vs. ac_cv_lib_readline_readline should be the same. > HAVE_READLINE vs. HAVE_READLINE_READLINE_H should be the same. I solved it slightly differently. I

Re: Opening a can of worms: a readline gnulib module?

Simon Josefsson wrote: > So the entire M4 file read as below now. Correct? gl_cv_lib_readline vs. ac_cv_lib_readline_readline should be the same. HAVE_READLINE vs. HAVE_READLINE_READLINE_H should be the same. After this, you can commit it if it works. Let's see whether it also needs mention of l

Re: Opening a can of worms: a readline gnulib module?

Bruno Haible <[EMAIL PROTECTED]> writes: > Simon Josefsson wrote: >> >> > + printf ("%s", prompt); >> > >> > You can simplify that to >> > >> > fputs (prompt); > > Oops, I meant: fputs (prompt, stdout). Sorry. Ah, added. >> +#include >> +#include >> + >> +/* Get specification. */ >> +#

Re: Opening a can of worms: a readline gnulib module?

> * Bruno Haible <[EMAIL PROTECTED]> [2005-08-11 16:46:35 +0200]: > >> > + AC_CHECK_LIB(readline, readline) > > Can you please use AC_LIB_LINKFLAGS (from lib-link.m4) instead? So > that the library is recognized (and the -rpath linker option is used) > when it is installed in the $PREFIX directory

Re: Opening a can of worms: a readline gnulib module?

Simon Josefsson wrote: > >> > + printf ("%s", prompt); > > > > You can simplify that to > > > > fputs (prompt); Oops, I meant: fputs (prompt, stdout). Sorry. > No, I don't want a newline. fputs() doesn't output an extra newline. Only puts() does. > +#include > +#include > + > +/* Get

Re: Opening a can of worms: a readline gnulib module?

Bruno Haible <[EMAIL PROTECTED]> writes: > Simon Josefsson wrote: >> Any objections to this readline module? There were some discussion, >> but no real objection from what I could tell. > > There was the objection that some packages need more from GNU readline > than just one function. Therefore

Re: Opening a can of worms: a readline gnulib module?

Sam Steingold <[EMAIL PROTECTED]> writes: >> * Simon Josefsson <[EMAIL PROTECTED]> [2005-07-16 22:30:27 +0200]: >> >> * readline.m4: New file. > > please take a look at > http://cvs.sourceforge.net/viewcvs.py/*checkout*/clisp/clisp/src/m4/readline.m4 Is there a particular part of that file w

Re: Opening a can of worms: a readline gnulib module?

Simon Josefsson wrote: > Any objections to this readline module? There were some discussion, > but no real objection from what I could tell. There was the objection that some packages need more from GNU readline than just one function. Therefore you will need to add more functions upon demand :-)

Re: Opening a can of worms: a readline gnulib module?

> * Simon Josefsson <[EMAIL PROTECTED]> [2005-07-16 22:30:27 +0200]: > > * readline.m4: New file. please take a look at http://cvs.sourceforge.net/viewcvs.py/*checkout*/clisp/clisp/src/m4/readline.m4 -- Sam Steingold (http://www.podval.org/~sds) running w2k

Re: Opening a can of worms: a readline gnulib module?

Simon Josefsson <[EMAIL PROTECTED]> writes: > Initial attempt. Tested on one platform with and without the readline > library inside GNU SASL. Any objections to this readline module? There were some discussion, but no real objection from what I could tell. There were no further discussion afte

Re: Opening a can of worms: a readline gnulib module?

Initial attempt. Tested on one platform with and without the readline library inside GNU SASL. 2005-07-16 Simon Josefsson <[EMAIL PROTECTED]> * readline.m4: New file. 2005-07-16 Simon Josefsson <[EMAIL PROTECTED]> * modules/readline: New file. 2005-07-16 Simon Josefsson

Re: Opening a can of worms: a readline gnulib module?

Stepan Kasal <[EMAIL PROTECTED]> writes: > Hello, > > On Sat, Jul 16, 2005 at 10:53:45AM +0200, Simon Josefsson wrote: >> All of this is hypothetical though, since it doesn't look like adding >> the readline library as a gnulib module will happen now. > > Why not? I don't see any reason against t

Re: Opening a can of worms: a readline gnulib module?

Hello, On Sat, Jul 16, 2005 at 10:53:45AM +0200, Simon Josefsson wrote: > All of this is hypothetical though, since it doesn't look like adding > the readline library as a gnulib module will happen now. Why not? I don't see any reason against the "readline stub" module you proposed. Bruno point

Re: Opening a can of worms: a readline gnulib module?

Bruno Haible <[EMAIL PROTECTED]> writes: > Simon Josefsson wrote: >> Do you think a "readline" module such as the above would be a >> candidate for gnulib? > > For application that only use this main entrypoint, yes. But other > applications need to customize the library's behaviour > (rl_basic_wo

Re: [bug-gnulib] Opening a can of worms: a readline gnulib module?

Simon Josefsson wrote: > Do you think a "readline" module such as the above would be a > candidate for gnulib? For application that only use this main entrypoint, yes. But other applications need to customize the library's behaviour (rl_basic_word_break_characters, rl_basic_quote_characters, rl_co

Opening a can of worms: a readline gnulib module?

Hi. In GNU SASL I use readline in the command line interface to prompt the user for some data (e.g., username). But readline is not always available, so I use an autoconf test: AC_CHECK_HEADERS(readline/readline.h) AC_CHECK_LIB(readline, readline) AM_CONDITIONAL(READLINE, test "$ac_cv_lib_readli