Re: Possible spurious cycle detection with fts

2005-08-24 Thread Jim Meyering
I've just committed that patch. Jim Meyering <[EMAIL PROTECTED]> wrote: ... > Thanks for reporting that. > With the following changes, > ./gnulib-tool --test fts > once again passes. > > 2005-08-24 Jim Meyering <[EMAIL PROTECTED]> > > * modules/fcntl-safer: New module. > * modules/

Re: Possible spurious cycle detection with fts

2005-08-24 Thread Paul Eggert
Jim Meyering <[EMAIL PROTECTED]> writes: > I'll hold off on the commit until Paul signs off on it. That looks good to me. Thanks for doing the merge. ___ bug-gnulib mailing list bug-gnulib@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnulib

Re: Possible spurious cycle detection with fts

2005-08-24 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: > Jim Meyering meyering.net> writes: >> I've just checked in these changes: >> >> 2005-08-14 Jim Meyering meyering.net> >> Sync from coreutils. ... > This patch breaks fts, as used by CVS findutils, because fcntl--.h is not part > of a gnulib module ye

Re: Possible spurious cycle detection with fts

2005-08-23 Thread Eric Blake
Jim Meyering meyering.net> writes: > I've just checked in these changes: > > 2005-08-14 Jim Meyering meyering.net> > > Sync from coreutils. > > > * fts.c [! _LIBC]: Include "lstat.h" rather than rolling our own. > * fts.c (fd_safer): Remove decl. > Include fcntl--.h

Re: Possible spurious cycle detection with fts

2005-08-14 Thread Jim Meyering
Jim Meyering <[EMAIL PROTECTED]> wrote: > James Youngman <[EMAIL PROTECTED]> wrote: >> This patch resolves my problem; thanks. Might I suggest though that >> you enhance the ChangeLog entry to describe the problem as well as the >> solution? > > This change requires some comment changes, too. > I'

Re: Possible spurious cycle detection with fts

2005-08-09 Thread Jim Meyering
James Youngman <[EMAIL PROTECTED]> wrote: > This patch resolves my problem; thanks. Might I suggest though that > you enhance the ChangeLog entry to describe the problem as well as the > solution? This change requires some comment changes, too. I'll do both.

Re: Possible spurious cycle detection with fts

2005-08-09 Thread James Youngman
On Tue, Aug 09, 2005 at 05:34:17PM +0200, Jim Meyering wrote: > 2005-08-09 Jim Meyering <[EMAIL PROTECTED]> > > * fts-cycle.c (setup_dir, enter_dir, leave_dir, free_dir): > Use the hash-table-based cycle-detection code not just when > FTS_TIGHT_CYCLE_CHECK if specified, but al

Re: Possible spurious cycle detection with fts

2005-08-09 Thread Jim Meyering
James Youngman <[EMAIL PROTECTED]> wrote: > If I invoke fts_open() with the FTS_LOGICAL flag and do not set > FTS_TIGHT_CYCLE_CHECK, then fts_read() returns FTS_DC in > ent->fts_info. However, with the same directory layout FTS_DC is not > set if FTS_TIGHT_CYCLE_CHECK is set. > > fts_options

Possible spurious cycle detection with fts

2005-08-08 Thread James Youngman
Hello, I'm still investigating this problem, but I'm seeing some odd behaviour with fts(). I have a directory layout like this:- $ find find1 -ls 12996934 drwxr-xr-x 3 jamesusers4096 Aug 8 20:33 find1 12997054 drwxr-xr-x 2 jamesusers4096 Aug 8 20:33 find1/di