Another incorrect 'Link' section is the one in the 'regex' module: - It needs to inherit the link directive from the 'lock' module. This is needed on AIX 7 (and probably on HP-UX 11.11, see the earlier report [1][2]). - It also needs a reference to libintl. (Reported in [3].)
Paul's patch in response to [1][2] fixed the regex-tests module. The $(LIB_PTHREAD) addition, however, is redundant: None of the dependencies of the 'regex-tests' module sets a LIB_PTHREAD variable; therefore this reference expands to empty. [1] http://lists.gnu.org/archive/html/bug-gnulib/2013-10/msg00052.html [2] http://lists.gnu.org/archive/html/bug-gnulib/2013-10/msg00054.html [3] http://lists.gnu.org/archive/html/bug-gnulib/2013-02/msg00003.html 2019-01-04 Bruno Haible <br...@clisp.org> Fix incorrect 'Link' sections. * modules/regex (Link): Mention the link requirement of module 'lock'. * modules/regex-tests (Makefile.am): Don't use LIB_PTHREAD. diff --git a/modules/regex b/modules/regex index 278510c..7f50916 100644 --- a/modules/regex +++ b/modules/regex @@ -48,6 +48,7 @@ Include: <regex.h> Link: +$(LTLIBTHREAD) when linking with libtool, $(LIBTHREAD) otherwise $(LTLIBINTL) when linking with libtool, $(LIBINTL) otherwise License: diff --git a/modules/regex-tests b/modules/regex-tests index 30ca5fd..0782303 100644 --- a/modules/regex-tests +++ b/modules/regex-tests @@ -11,4 +11,4 @@ configure.ac: Makefile.am: TESTS += test-regex check_PROGRAMS += test-regex -test_regex_LDADD = $(LDADD) @LIBINTL@ $(LIBTHREAD) $(LIB_PTHREAD) +test_regex_LDADD = $(LDADD) @LIBINTL@ $(LIBTHREAD)
