Re: support for universal binaries on MacOS X (5/6)

2009-01-21 Thread Jim Meyering
Bruno Haible wrote: > Sorry for the delay. > >> I've reworked those patches accordingly, >> but didn't test on a MacOS X system. >> Since your name is on them, I'll wait until >> you acknowledge before pushing. ... > Sure, fine with me. You can put yourself into the ChangeLog entry, of course. > I

Re: support for universal binaries on MacOS X (5/6)

2009-01-16 Thread Bruno Haible
Hi Jim, Sorry for the delay. > I've reworked those patches accordingly, > but didn't test on a MacOS X system. > Since your name is on them, I'll wait until > you acknowledge before pushing. > > > From 6bfdd76f3f2e3b03be407dcfab7a231259d23d15 Mon Sep 17 00:00:00 2001 > From: Bruno Haible > Dat

Re: support for universal binaries on MacOS X (5/6)

2009-01-04 Thread Jim Meyering
Jim Meyering wrote: > Bruno Haible wrote: > ... >>> It looks to me like the change below is equivalent to yours, >> >> Ah, I see now what you mean. Fine with me. ... Hi Bruno, I've reworked those patches accordingly, but didn't test on a MacOS X system. Since your name is on them, I'll wait un

Re: support for universal binaries on MacOS X (5/6)

2009-01-01 Thread Bruno Haible
Peter O'Gorman wrote: > > The configure test whether mktime works produces the result "yes" in 32-bit > > mode and "no" in 64-bit mode. ... > > This is surprising, what is the reason for the 64 bit failure? It is not surprising when you look at the function bigtime_test in m4/mktime.m4. Bruno

Re: support for universal binaries on MacOS X (5/6)

2008-12-27 Thread Peter O'Gorman
Bruno Haible wrote: > Jim, > > The configure test whether mktime works produces the result "yes" in 32-bit > mode and "no" in 64-bit mode. In universal builds, we cannot manage these > different results (it would become a #ifdef mess). Therefore I propose to > combine the results to "no". OK to co

Re: support for universal binaries on MacOS X (5/6)

2008-12-26 Thread Jim Meyering
Bruno Haible wrote: ... >> It looks to me like the change below is equivalent to yours, > > Ah, I see now what you mean. Fine with me. > > I wouldn't have chosen this solution because it tears apart the > determination of the ac_cv_func_working_mktime into two parts, > one before the AC_CACHE_CHEC

Re: support for universal binaries on MacOS X (5/6)

2008-12-26 Thread Bruno Haible
Hi Jim, > It looks to me like the change below is equivalent to yours, Ah, I see now what you mean. Fine with me. I wouldn't have chosen this solution because it tears apart the determination of the ac_cv_func_working_mktime into two parts, one before the AC_CACHE_CHECK and one inside it (making

Re: support for universal binaries on MacOS X (5/6)

2008-12-26 Thread Jim Meyering
Bruno Haible wrote: >> That looks like it'd work fine > > It does work fine. I tested it :-) > >> but I'd like it even more if it were >> to set the cache variable to "no" *before* the use of AC_CACHE_CHECK. >> Then, this change would be more compact and would not affect the logical >> structure (

Re: support for universal binaries on MacOS X (5/6)

2008-12-26 Thread Bruno Haible
Hi Jim, > That looks like it'd work fine It does work fine. I tested it :-) > but I'd like it even more if it were > to set the cache variable to "no" *before* the use of AC_CACHE_CHECK. > Then, this change would be more compact and would not affect the logical > structure (i.e. no need for the

Re: support for universal binaries on MacOS X (5/6)

2008-12-26 Thread Jim Meyering
Bruno Haible wrote: > The configure test whether mktime works produces the result "yes" in 32-bit > mode and "no" in 64-bit mode. In universal builds, we cannot manage these > different results (it would become a #ifdef mess). Therefore I propose to > combine the results to "no". OK to commit? Hi

support for universal binaries on MacOS X (5/6)

2008-12-25 Thread Bruno Haible
Jim, The configure test whether mktime works produces the result "yes" in 32-bit mode and "no" in 64-bit mode. In universal builds, we cannot manage these different results (it would become a #ifdef mess). Therefore I propose to combine the results to "no". OK to commit? 2008-12-25 Bruno Haible