Re: [bug-gnulib] verify.h in C++? Boost has me worried.

2005-10-05 Thread Paul Eggert
Bruno Haible [EMAIL PROTECTED] writes: You really tortured your students with this beast?! :-) Well, not the whole thing. The current verify.h doesn't work with C++ - error types may not be defined in 'sizeof' expressions. Find appended a fix, tested with g++ 3.2.2 and 4.0.1. Thanks, I

getaddrinfo.h: HAVE_SYS_TYPES_H needed?

2005-10-05 Thread Jim Meyering
Hi Simon, I noticed that getaddrinfo.h guards the inclusion of sys/types.h with an #ifdef HAVE_SYS_TYPES_H. Do you know of a system that lacks sys/types.h? I don't see any other uses of HAVE_SYS_TYPES_H in gnulib. How about HAVE_SYS_SOCKET_H? At least poll.c uses sys/socket.h without the

Re: getaddrinfo.h: HAVE_SYS_TYPES_H needed?

2005-10-05 Thread Simon Josefsson
Jim Meyering [EMAIL PROTECTED] writes: Hi Simon, I noticed that getaddrinfo.h guards the inclusion of sys/types.h with an #ifdef HAVE_SYS_TYPES_H. Do you know of a system that lacks sys/types.h? Hi Jim! No, I don't. I don't see any other uses of HAVE_SYS_TYPES_H in gnulib. I removed the

memxor

2005-10-05 Thread Simon Josefsson
Hi. This is a helper module needed by the hmac-md5 crypto module that I'll post after this. What do you think? Ok to install? I am not sure about the prototype. Should it use 'char*'? 'int*'? The implementation XOR the data buffers char by char, but there is no inherent requirement that it

Re: hmac-md5

2005-10-05 Thread Simon Josefsson
Bruno Haible [EMAIL PROTECTED] writes: Simon Josefsson wrote: This is the HMAC-MD5 module, that depends on the MD5 module. What do you think? Ok to install? The reason I'm using hmac.h instead of hmac-md5.h is that I think hmac.h should contain the prototype for hmac_sha1 too, eventually.

Re: hmac-md5

2005-10-05 Thread Simon Josefsson
Bruno Haible [EMAIL PROTECTED] writes: For 'uint8_t', you can use the gnulib module 'stdint'. Or use 'unsigned char' if you don't want to. I just noticed that the 'stdint' module was GPL. Would it be possible to re-license it? Otherwise I'll just 'unsigned char*' or 'void*' for hmac-md5.

Re: stdint license

2005-10-05 Thread Bruno Haible
Simon Josefsson wrote: I just noticed that the 'stdint' module was GPL. Would it be possible to re-license it? Yes, done (assuming Oskar's agreement). Bruno ___ bug-gnulib mailing list bug-gnulib@gnu.org

FYI: getdelim.c needs SIZE_MAX

2005-10-05 Thread Derek Price
Paul's recent change to getdelim.c breaks the build on at least NetBSD 1.6.1: 2005-10-03 Paul Eggert [EMAIL PROTECTED] * getdelim.c: Include getdelim.h first. Include limits.h. (SSIZE_MAX): New macro, if not already defined. (getdelim): Fix buffer overrun on 64-bit

Re: FYI: getdelim.c needs SIZE_MAX

2005-10-05 Thread Derek Price
Simon Josefsson wrote: Derek Price [EMAIL PROTECTED] writes: may not be defined. I've installed the attached patch, ripped verbatim from serveral other modules. Shouldn't we use the size_max module instead? I'm not sure. Some 18 modules currently don't, defining SIZE_MAX

Re: getaddrinfo.h: HAVE_SYS_TYPES_H needed?

2005-10-05 Thread Paul Eggert
Simon Josefsson [EMAIL PROTECTED] writes: The tests for these headers in getaddrinfo.m4 should probably be removed eventually. No time like the present, right? I installed this: 2005-10-05 Paul Eggert [EMAIL PROTECTED] * getaddrinfo.m4 (gl_PREREQ_GETADDRINFO): Don't check for

Re: memxor

2005-10-05 Thread Paul Eggert
Simon Josefsson [EMAIL PROTECTED] writes: I am not sure about the prototype. Should it use 'char*'? 'int*'? If its name is mem* then it should use void *, for consistency. The current implementation uses 'restrict', so memxor.m4 should AC_REQUIRE([gl_C_RESTRICT]) and the memxor module should

Re: hmac-md5

2005-10-05 Thread Paul Eggert
Simon Josefsson [EMAIL PROTECTED] writes: Has anyone used md5_buffer from the md5 module on a platform with char that is larger than 1 byte? Do you mean a host where UCHAR_MAX 255? I doubt whether anyone has done that. POSIX requires that UCHAR_MAX == 255. A small fraction of GNU code is