Re: [RFC] Adding a real HashTable implementation to gnulib

2018-11-26 Thread Darshit Shah
Here are the links to the sources in the GNU Wget tree: http://git.savannah.gnu.org/cgit/wget.git/tree/src/hash.h http://git.savannah.gnu.org/cgit/wget.git/tree/src/hash.c At first sight, the implementation in PSPP looks a lot more concise. Also, it's usage of fewer preprocessor statements makes

Re: A new module: bitset

2018-11-26 Thread Akim Demaille
Hi Paul! > Le 25 nov. 2018 à 20:43, Paul Eggert a écrit : > > One top-level question is how does memory allocation work? Emacs has its own > memory allocator, and doesn't want to use plain malloc. It has its own > xmalloc implementation; will that suffice? The current implementation uses

Re: [RFC] Adding a real HashTable implementation to gnulib

2018-11-26 Thread Ben Pfaff
Much as I like the PSPP hmaps, it probably makes sense for any hash table implementation in gnulib to match the existing code. On Tue, Nov 27, 2018 at 02:02:17AM +0100, Darshit Shah wrote: > Here are the links to the sources in the GNU Wget tree: > >

Re: localename: Fix gettext test failures on mingw

2018-11-26 Thread Eli Zaretskii
> From: Bruno Haible > Cc: bug-gnulib@gnu.org > Date: Sun, 25 Nov 2018 19:27:44 +0100 > > > It defines symbols based on LC_MESSAGES and exposes them > > to Scheme. > > What was the problem with that? Since guile is based on the > platform's runtime + gnulib, not the platform's runtime alone, >

[RFC] Adding a real HashTable implementation to gnulib

2018-11-26 Thread Darshit Shah
I recently tried to use the hash table implementation in gnulib which resides in the "hash" module. However, I quickly realised that the hash table in gnulib seems to be what is otherwise popularly known as a hash set, i.e., it supports storing and retrieving just values from the structure. On

Re: [RFC] Adding a real HashTable implementation to gnulib

2018-11-26 Thread Ben Pfaff
On Tue, Nov 27, 2018 at 12:16:16AM +0100, Darshit Shah wrote: > I recently tried to use the hash table implementation in gnulib which resides > in the "hash" module. However, I quickly realised that the hash table in > gnulib > seems to be what is otherwise popularly known as a hash set, i.e., it