Re: [PATCH] gnulib-tool.py: Fix missing space.

2025-04-05 Thread Collin Funk
Hi Eric,

Eric Blake  writes:

> Noticed this while working on m4.  Pushing as obvious, since it is a
> difference between the .sh and .py versions.  I'm not sure if it is
> worth trying to enhance the gnulib-tool testsuite to add coverage for
> error messages like this.

Thanks!

I don't think a test case is needed for this. The tests were more
important to make sure the dependency tracking was correct and written
files were the same.

Collin



[PATCH] gnulib-tool.py: Fix missing space.

2025-04-05 Thread Eric Blake
* pygnulib/main.py (main_with_exception_handling): Typo fix.
---

Noticed this while working on m4.  Pushing as obvious, since it is a
difference between the .sh and .py versions.  I'm not sure if it is
worth trying to enhance the gnulib-tool testsuite to add coverage for
error messages like this.

 ChangeLog| 5 +
 pygnulib/main.py | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index 6d7435f491..076065290f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2025-04-05  Eric Blake  
+
+   gnulib-tool.py: Fix missing space.
+   * pygnulib/main.py (main_with_exception_handling): Typo fix.
+
 2025-04-04  Eric Blake  

tests: Better name in init.sh usage.
diff --git a/pygnulib/main.py b/pygnulib/main.py
index 3b1b988f70..77eed3d4ff 100644
--- a/pygnulib/main.py
+++ b/pygnulib/main.py
@@ -1486,7 +1486,7 @@ def main_with_exception_handling() -> None:
 message += 'cannot find %s - make sure you run gnulib-tool 
from within your package\'s directory' % errinfo
 elif errno == 4:
 message += 'minimum supported autoconf version is 2.64. Try 
adding'
-message += 'AC_PREREQ([%s])' % DEFAULT_AUTOCONF_MINVERSION
+message += ' AC_PREREQ([%s])' % DEFAULT_AUTOCONF_MINVERSION
 message += ' to your configure.ac.'
 elif errno == 5:
 message += '%s is expected to contain gl_M4_BASE([%s])' % 
(repr(os.path.join(errinfo, 'gnulib-comp.m4')), repr(errinfo))

base-commit: 3773db653242ab7165cd300295c27405e4f9cc79
prerequisite-patch-id: 85b7e71612321847476c13d49014538d30bc3f21
prerequisite-patch-id: e994edfde1581a45ec69a0fe708cc771ebac4484
prerequisite-patch-id: 9b2083f67a269826616088dd482e8e54bbde8058
prerequisite-patch-id: fa32fb70b42b26fd61e1afb2f6fc9b292fba5f83
-- 
2.49.0