Re: [PATCH] dfa: addition of new state on demand

2016-11-26 Thread Norihiro Tanaka
Thanks for the review. I confirmed your changes, and I found no problem. > CC'ing this to grep-devel since that's where the hardy band of dfa > consumers hang out. I will also do it in next post for dfa.

Re: [PATCH] dfa: addition of new state on demand

2016-11-25 Thread Paul Eggert
Jim Meyering wrote: I see one typo in your 2nd change's log: s/cdalls/calls/ Omit unnecessary cdalls to zeroset. Thanks, I fixed that.

Re: [PATCH] dfa: addition of new state on demand

2016-11-25 Thread Jim Meyering
On Fri, Nov 25, 2016 at 11:03 AM, Paul Eggert wrote: > Norihiro Tanaka wrote: >> >> Can anyone review this change? > > > Thanks for doing all that, and sorry about the late review. I reviewed it, > tweaked its commit message and propagated that into ChangeLog (the gnulib > practice), and installed

Re: [PATCH] dfa: addition of new state on demand

2016-11-25 Thread Paul Eggert
Norihiro Tanaka wrote: Can anyone review this change? Thanks for doing all that, and sorry about the late review. I reviewed it, tweaked its commit message and propagated that into ChangeLog (the gnulib practice), and installed the result into gnulib, with two followup patches that I hope ar

Re: [PATCH] dfa: addition of new state on demand

2016-11-21 Thread Norihiro Tanaka
On Mon, 17 Oct 2016 22:00:33 +0900 Norihiro Tanaka wrote: > > On Mon, 17 Oct 2016 11:45:43 +0900 > Norihiro Tanaka wrote: > > > When dfa builds a state, generates all next states. However, I believe > > most of them are not used. > > > > This patch changes as that when dfa builds a state, g

Re: [PATCH] dfa: addition of new state on demand

2016-10-17 Thread Norihiro Tanaka
On Mon, 17 Oct 2016 11:45:43 +0900 Norihiro Tanaka wrote: > When dfa builds a state, generates all next states. However, I believe > most of them are not used. > > This patch changes as that when dfa builds a state, generates a next > state including next input character only. > > The followi