Hi Paul,
> Thanks for the review; I installed the attached to try to address the issues
> you
> raised.
Thanks. It fixes all the qualms I had with it.
Just one followup (trivial):
2017-02-16 Bruno Haible
xbinary-io: Fix inlining.
* lib/xbinary-io.c: Set XBINARY_IO_INLINE,
Thanks for the review; I installed the attached to try to address the issues you
raised.
>From 820fa6ad064bf3ba81dc9e2cd7fa2b98bb270902 Mon Sep 17 00:00:00 2001
From: Paul Eggert
Date: Thu, 16 Feb 2017 00:17:56 -0800
Subject: [PATCH] xbinary-io: rename from xsetmode
This patch is taken from sugg
Hi Paul,
> -/* set_binary_mode (fd, mode)
> - sets the binary/text I/O mode of file descriptor fd to the given mode
> - (must be O_BINARY or O_TEXT) and returns the previous mode. */
> +/* Set FD's mode to MODE. Return the old mode if successful, -1
> + (setting errno) on failure. */
The
