Re: Correct but unhelpful VLA warning vs. gnulib's gettext.h; can we eliminate the false positive?

2019-01-13 Thread Pádraig Brady
On 09/07/11 15:32, James Youngman wrote: > To be clear before we start, gnulib is doing the right thing here. It > contains this code in lib/gettext.h:- > > static const char * > dcpgettext_expr (const char *domain, > const char *msgctxt, const char *msgid, >

Re: Correct but unhelpful VLA warning vs. gnulib's gettext.h; can we eliminate the false positive?

2011-07-10 Thread James Youngman
On Sun, Jul 10, 2011 at 5:47 AM, Paul Eggert egg...@cs.ucla.edu wrote: On 07/09/11 15:32, James Youngman wrote: Is there a way of eliminating this false positive which doesn't force me to give up -Wvla? You can use a pragma in the module that you've audited. The pragma would tell GCC, don't

Re: Correct but unhelpful VLA warning vs. gnulib's gettext.h; can we eliminate the false positive?

2011-07-10 Thread Simon Josefsson
I ran into this issue as well some time ago, and my solution was to remove those definitions from my local gettext.h copy. It is a non-solution, but I thought I should mention it in case your project (like gsasl) does not use those gettext.h functions and you just want to silence the warning.

Re: Correct but unhelpful VLA warning vs. gnulib's gettext.h; can we eliminate the false positive?

2011-07-10 Thread James Youngman
On Mon, Jul 11, 2011 at 1:11 AM, Paul Eggert egg...@cs.ucla.edu wrote: On 07/10/11 02:16, James Youngman wrote: A function-level pragma would probably be ideal here, but unfortunately they can only be used to tweak optimisation and function attributes. Can you do #pragma GCC diagnostic push

Re: Correct but unhelpful VLA warning vs. gnulib's gettext.h; can we eliminate the false positive?

2011-07-10 Thread Paul Eggert
Can you do #pragma GCC diagnostic push I'll try it next week. It's not documented in the GCC-4.4 Texinfo manual, though; perhaps it's a recent introduction. Yes, it's introduced in GCC 4.6.0. http://gcc.gnu.org/gcc-4.6/changes.html Presumably one can use it if available, and fall back on

Re: Correct but unhelpful VLA warning vs. gnulib's gettext.h; can we eliminate the false positive?

2011-07-09 Thread Paul Eggert
On 07/09/11 15:32, James Youngman wrote: Is there a way of eliminating this false positive which doesn't force me to give up -Wvla? You can use a pragma in the module that you've audited. The pragma would tell GCC, don't waste my time warning about VLAs in this module.