Re: Replace use of obsolete Emacs feature "write-file-hooks"

2018-03-07 Thread Paul Eggert
On 03/07/2018 03:58 PM, Karl Berry wrote: >    doc/maintain.texi. > > bug-standa...@gnu.org Whaddya know, it turns out that I have the bits to do bug-standards after all; I'd forgotten about that. I installed a patch and propagated it into Gnulib. build-aux/texinfo.tex

Re: Replace use of obsolete Emacs feature "write-file-hooks"

2018-03-07 Thread Karl Berry
build-aux/texinfo.tex bug-texi...@gnu.org and doc/maintain.texi. bug-standa...@gnu.org I think Karl Berry can do those so I'll CC: him. Technically I can still commit to the repos, but I think it would be better if I didn't step in. (I can't help but remark that backward

Re: Replace use of obsolete Emacs feature "write-file-hooks"

2018-03-07 Thread Ben Elliston
On Wed, Mar 07, 2018 at 11:46:56AM -0800, Paul Eggert wrote: > These are all upstream from Gnulib. For the first two, I'm attaching > a proposed patch and CC'ing this to config-patches. For the last > one, I fixed the upstream and propagated it to Gnulib. Applied. Ben signature.asc

Re: Replace use of obsolete Emacs feature "write-file-hooks"

2018-03-07 Thread Paul Eggert
On 03/07/2018 09:32 AM, Glenn Morris wrote: Thanks for replacing the obsolete forms. A few files were already using write-file-functions; I don't know if you want to change those to before-save-hook, for consistency. From today's gnulib: build-aux/config.sub build-aux/config.guess

Re: Replace use of obsolete Emacs feature "write-file-hooks"

2018-03-07 Thread Glenn Morris
Thanks for replacing the obsolete forms. A few files were already using write-file-functions; I don't know if you want to change those to before-save-hook, for consistency. >From today's gnulib: build-aux/config.sub build-aux/config.guess doc/standards.texi

Re: Replace use of obsolete Emacs feature "write-file-hooks"

2018-03-07 Thread Paul Eggert
Glenn Morris wrote: Please replace "write-file-hooks" with "before-save-hook". I did that in all files maintained in Gnulib, along with files we're copying from Automake (I updated Automake), by installing the attached. Two files remain that I don't believe I have commit privileges on

Re: Replace use of obsolete Emacs feature "write-file-hooks"

2018-03-07 Thread Paul Eggert
Glenn Morris wrote: I assumed any utility to keeping the time stamps update was solely for edits in gnulib itself. I assumed otherwise, in that if a change was made downstream by hand they'd want the timestamps to be updated. By the way, I would rather remove these timestamps as they are

Re: Replace use of obsolete Emacs feature "write-file-hooks"

2018-03-06 Thread Glenn Morris
Paul Eggert wrote (on Tue, 6 Mar 2018 at 19:43 -0800): > That would make sense if we assume that Gnulib source files live in a > directory > controlled by the .dir-locals.el file. However, Gnulib is designed to copy > source files hither and yon, and it'd be a pain to arrange to update the >

Re: Replace use of obsolete Emacs feature "write-file-hooks"

2018-03-06 Thread Paul Eggert
Glenn Morris wrote: PS If you drop Emacs < 23.1 (released July 2009), you can switch to a single .dir-locals.el file (rather than having the same stanza in multiple source files) That would make sense if we assume that Gnulib source files live in a directory controlled by the .dir-locals.el

Re: Replace use of obsolete Emacs feature "write-file-hooks"

2018-03-06 Thread Glenn Morris
PS If you drop Emacs < 23.1 (released July 2009), you can switch to a single .dir-locals.el file (rather than having the same stanza in multiple source files), as someone pointed out in http://lists.gnu.org/r/bug-gnulib/2011-02/msg00282.html