Re: The non-recursive-gnulib-prefix-hack module

On Wed, Feb 1, 2017 at 2:28 PM, John W. Eaton wrote: > Is there anything I can do to help get this change accepted as part of > gnulib? > > I'd really like to be able to use a completely non-recursive Makefile for > Octave. Hi John, A great step in the right direction would be to ensure that your

Re: The non-recursive-gnulib-prefix-hack module

Is there anything I can do to help get this change accepted as part of gnulib? I'd really like to be able to use a completely non-recursive Makefile for Octave. jwe On 11/28/2016 12:40 AM, John W. Eaton wrote: On 11/27/2016 06:18 PM, Bruno Haible wrote: John, I added AC_CONFIG_LIBOB

Re: The non-recursive-gnulib-prefix-hack module

On 11/27/2016 06:18 PM, Bruno Haible wrote: John, I added AC_CONFIG_LIBOBJ_DIR([libgnu]) to my configure.ac file. Maybe gnulib-tool could do this automatically if --non-recursive-makefile is specified? gnulib-tool does not rely on AC_LIBOBJ and friends, because these autoconf macros ass

Re: The non-recursive-gnulib-prefix-hack module

John, > I added > >AC_CONFIG_LIBOBJ_DIR([libgnu]) > > to my configure.ac file. Maybe gnulib-tool could do this automatically > if --non-recursive-makefile is specified? gnulib-tool does not rely on AC_LIBOBJ and friends, because these autoconf macros assume that there is only one lib/ dir

Re: The non-recursive-gnulib-prefix-hack module

On 11/27/2016 05:02 PM, Bruno Haible wrote: * I would add a check to make sure that --non-recursive-makefile is only used together with the --makefile-name option. I cannot see how/why someone would use --non-recursive-makefile without --makefile-name. This simplies some of the logic (e.g.

Re: The non-recursive-gnulib-prefix-hack module

On 11/27/2016 04:29 PM, Bruno Haible wrote: When you specify --makefile-name=module.mk, gnulib-tool knows that you don't want a top-level Makefile.am and does not generate AUTOMAKE_OPTIONS and generates augmentations (+=) of the other variables instead of assignments. OK, I didn't realize that

Re: The non-recursive-gnulib-prefix-hack module

Hi John, > I also started working on a change to replace the > non-recursive-gnulib-prefix-hack module with a --non-recursive-makefile > option for gnulib-tool. My initial attempt is attached. Great! A couple of small remarks: * I would add a check to make sure that --non-recursive-makefile

Re: The non-recursive-gnulib-prefix-hack module

Hi John, > I did that for Octave and the resulting files are attached. This is great! > The gnulib-generated file is Makefile.am. The edited file that I > included in Octave's main Makefile.am file is module.mk. > ... > Things like AUTOMAKE_OPTIONS need to be omitted. We can assume that the

Re: The non-recursive-gnulib-prefix-hack module

On 11/27/2016 07:52 AM, John W. Eaton wrote: On 10/22/2016 03:04 PM, Bruno Haible wrote: The idea would be to have gnulib-tool emit the correct code for the {Bison,coreutils,Octave} case right away, triggered by some command line option. If you want to help us here, please use the *current* gn

Re: The non-recursive-gnulib-prefix-hack module

On 07/11/16 02:35, Bruno Haible wrote: > Hi Pádraig, > >>> lib/gnulib.mk:32: error: required file '$gl_source_base/alloca.c' not found >>> Makefile.am:226: 'lib/local.mk' included from here >>> lib/local.mk:1: 'lib/gnulib.mk' included from here >>> autoreconf: automake failed with exit status:

Re: The non-recursive-gnulib-prefix-hack module

Hi Pádraig, > > lib/gnulib.mk:32: error: required file '$gl_source_base/alloca.c' not found > > Makefile.am:226: 'lib/local.mk' included from here > > lib/local.mk:1: 'lib/gnulib.mk' included from here > > autoreconf: automake failed with exit status: 1 > > ./bootstrap: autoreconf failed ... >

Re: The non-recursive-gnulib-prefix-hack module

On 05/11/16 18:00, Pádraig Brady wrote: > On 22/10/16 18:25, Bruno Haible wrote: >> Hi Jim, >> 2016-10-16 Bruno Haible gnulib-tool: Make --create-testdir on all modules work again. * gnulib-tool (func_create_testdir): Don't include the non-recursi

Re: The non-recursive-gnulib-prefix-hack module

On 22/10/16 18:25, Bruno Haible wrote: > Hi Jim, > >>> 2016-10-16 Bruno Haible >>> >>> gnulib-tool: Make --create-testdir on all modules work again. >>> * gnulib-tool (func_create_testdir): Don't include the >>> non-recursive-gnulib-prefix-hack module. >> That looks fine

Re: The non-recursive-gnulib-prefix-hack module

Jim Meyering wrote: > I've confirmed that with that, coreutils still bootstraps and passes > "make distcheck". Thank you for the testing, Jim. Pushed. Bruno -- In memoriam Hana Brady

Re: The non-recursive-gnulib-prefix-hack module

On Sat, Oct 22, 2016 at 10:25 AM, Bruno Haible wrote: > This is better now. But still better would be to not hardcode 'lib' at all, > and instead use whatever value was passed to gnulib-tool via --source-base. > Below is a proposed patch. (The variable $gl_source_base is already used in a > simila

Re: The non-recursive-gnulib-prefix-hack module

On Sat, Oct 22, 2016 at 19:25:46 +0200, Bruno Haible wrote: > This is better now. But still better would be to not hardcode 'lib' at all, > and instead use whatever value was passed to gnulib-tool via --source-base. > Below is a proposed patch. (The variable $gl_source_base is already used in a > s

Re: The non-recursive-gnulib-prefix-hack module

Hi Mike, > Hi, I had attempted to get non-recursive-gnulib-prefix-hack working with > Octave (where the gnulib subdirectory is not named 'lib'). I sent a > patch and a query for help to bug-gnulib last year and attracted no > interest, I assume because there are very few users. > > Original (work

Re: The non-recursive-gnulib-prefix-hack module

Hi Jim, > > 2016-10-16 Bruno Haible > > > > gnulib-tool: Make --create-testdir on all modules work again. > > * gnulib-tool (func_create_testdir): Don't include the > > non-recursive-gnulib-prefix-hack module. > That looks fine. Thanks again. OK, I've pushed it. > > 4)

Re: The non-recursive-gnulib-prefix-hack module

On Sun, Oct 16, 2016 at 5:13 AM, Bruno Haible wrote: > Hi Jim, all, > > When I try to use the gnulib-tool --create-testdir option to produce a testdir > for all modules, it encounters errors and produces no toplevel Makefile.in: > > $ ./gnulib-tool --create-testdir --with-tests --dir=/tmp/testdir1