Re: getaddrinfo.h: HAVE_SYS_TYPES_H needed?

[Simon Josefsson]

Jim Meyering [EMAIL PROTECTED] writes:

 Hi Simon,

 I noticed that getaddrinfo.h guards the inclusion of sys/types.h
 with an #ifdef HAVE_SYS_TYPES_H.
 Do you know of a system that lacks sys/types.h?

Hi Jim!  No, I don't.

 I don't see any other uses of HAVE_SYS_TYPES_H in gnulib.

I removed the check.

 How about HAVE_SYS_SOCKET_H?
 At least poll.c uses sys/socket.h without the conditional.

 It's best to avoid the conditionals, when possible.

Mingw32 doesn't have sys/socket.h, but gnulib doesn't support it
anyway, so I removed the check.  The proper fix on mingw32 would be to
supply, in a gnulib module, some working sys/socket.h files.

What about netdb.h then?  Is there any system that lack it?

I'm leaving the tests in getaddrinfo.m4 for a while, so that more
debug information end up in config.log.

Thanks,
Simon


___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib

Re: getaddrinfo.h: HAVE_SYS_TYPES_H needed?

[Paul Eggert]

Simon Josefsson [EMAIL PROTECTED] writes:

 The tests for these headers in getaddrinfo.m4 should probably be
 removed eventually.

No time like the present, right?  I installed this:

2005-10-05  Paul Eggert  [EMAIL PROTECTED]

* getaddrinfo.m4 (gl_PREREQ_GETADDRINFO): Don't check for
sys/socket.h, netdb.h, sys/types.h; the checks areno longer
needed, since the source code now assumes these .h files.

--- getaddrinfo.m4  1 Oct 2005 11:19:16 -   1.10
+++ getaddrinfo.m4  5 Oct 2005 21:41:31 -   1.12
@@ -1,4 +1,4 @@
-# getaddrinfo.m4 serial 6
+# getaddrinfo.m4 serial 7
 dnl Copyright (C) 2004, 2005 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -19,30 +19,18 @@ AC_DEFUN([gl_PREREQ_GETADDRINFO], [
   AC_REQUIRE([gl_SOCKET_FAMILIES])
   AC_REQUIRE([AC_C_INLINE])
   AC_REQUIRE([AC_GNU_SOURCE])
-  AC_CHECK_HEADERS_ONCE(sys/socket.h netdb.h sys/types.h netinet/in.h)
+  AC_CHECK_HEADERS_ONCE(netinet/in.h)
   AC_CHECK_DECLS([getaddrinfo, freeaddrinfo, gai_strerror],,,[
   /* sys/types.h is not needed according to POSIX, but the
  sys/socket.h in i386-unknown-freebsd4.10 and
  powerpc-apple-darwin5.5 required it. */
-#ifdef HAVE_SYS_TYPES_H
-# include sys/types.h
-#endif
-#ifdef HAVE_SYS_SOCKET_H
-# include sys/socket.h
-#endif
-#ifdef HAVE_NETDB_H
-# include netdb.h
-#endif
+#include sys/types.h
+#include sys/socket.h
+#include netdb.h
 ])
   AC_CHECK_TYPES([struct addrinfo],,,[
-#ifdef HAVE_SYS_TYPES_H
-# include sys/types.h
-#endif
-#ifdef HAVE_SYS_SOCKET_H
-# include sys/socket.h
-#endif
-#ifdef HAVE_NETDB_H
-# include netdb.h
-#endif
+#include sys/types.h
+#include sys/socket.h
+#include netdb.h
 ])
 ])


___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib