Re: install-sh and $RANDOM

2016-10-18 Thread Eric Blake
On 10/17/2016 11:46 PM, co...@sdf.org wrote: > On Mon, Oct 17, 2016 at 04:56:05PM -0500, Eric Blake wrote: >> Second, your claim that things are "spuriously bad if $RANDOM does not >> exist" is false. Look at the full context: >> >> tmpdir=${TMPDIR-/tmp}/ins$RANDOM-$$ >>

Re: install-sh and $RANDOM

2016-10-18 Thread coypu
On Tue, Oct 18, 2016 at 06:24:03AM -0500, Eric Blake wrote: > On 10/17/2016 11:46 PM, co...@sdf.org wrote: > > On Mon, Oct 17, 2016 at 04:56:05PM -0500, Eric Blake wrote: > >> Second, your claim that things are "spuriously bad if $RANDOM does not > >> exist" is false. Look at the full context: >

Re: install-sh and $RANDOM

2016-10-17 Thread coypu
On Mon, Oct 17, 2016 at 04:56:05PM -0500, Eric Blake wrote: > Second, your claim that things are "spuriously bad if $RANDOM does not > exist" is false. Look at the full context: > > tmpdir=${TMPDIR-/tmp}/ins$RANDOM-$$ > trap 'ret=$?; rmdir "$tmpdir/d" "$tmpdir"

Re: install-sh and $RANDOM

2016-10-17 Thread Ben Pfaff
On Mon, Oct 17, 2016 at 04:56:05PM -0500, Eric Blake wrote: > You're not the first person to complain that $RANDOM is a bashism, and > this is not the first time we've had to retort that our use of $RANDOM > is a nicety, but not a necessity, and that the code is perfectly safe > and tested on

Re: install-sh and $RANDOM

2016-10-17 Thread Eric Blake
On 10/17/2016 03:58 PM, co...@sdf.org wrote: > Hi, > > in build-aux/install-sh scriptversion=2016-01-11.22 line 327 > tmpdir=${TMPDIR-/tmp}/ins$RANDOM-$$ > ... things which are spuriously bad if $RANDOM does not exist ... Thanks for the report. However, you've made two mistakes. First, gnulib