Hi Padraig,
> In the attached I added a single extra orig_buffersize variable to
> control an extra read-only scan.
Thanks, it looks good.
The other recursive call to quotearg_buffer_restyled
return quotearg_buffer_restyled (buffer, buffersize, arg, argsize,
On 10/18/2016 05:15 AM, Bruno Haible wrote:
>
> How about this? You are doing multiple passes through the argument string
> anyway now. (Originally quotearg was meant as a single-pass implementation,
> but it isn't any more.) So
> - remove the code block of lines 711..720,
> - instead, before t
Bruno Haible wrote:
> I disagree with the removal of the '%' checks in tests/test-sh-quote.c
Agreed. There is a disparity now because there is a switch
from a longer (shell) to a more concise (c) quoting style
in certain cases (when just a single quote is encountered).
This is fine for most interf
Hi Pádraig,
> > I disagree with the removal of the '%' checks in tests/test-sh-quote.c
>
> Agreed. There is a disparity now because there is a switch
> from a longer (shell) to a more concise (c) quoting style
> in certain cases (when just a single quote is encountered).
And what happens more pr
Hi Pádraig,
> The attached should fix up those tests.
I disagree with the removal of the '%' checks in tests/test-sh-quote.c
and tests/test-system-quote-main.c. These checks are there to guarantee
that the functions won't write past the allocated buffer. For example,
sh-quote.h specifies how larg
On 16/10/16 17:49, Bruno Haible wrote:
> Hi Pádraig,
>
> On a glibc system (glibc 2.15, Linux 3.8) I get these test failures
> from a gnulib testdir:
>
> 1) For module 'quotearg':
>
> FAIL: test-quotearg.sh
>
> $ LOCALE=fr_FR.UTF-8 LOCALEDIR=locale ./test-quotearg
> test-quotearg.h:53: assertio
