Re: a bad use of strerror_r

2016-11-04 Thread Eric Blake
On 10/16/2016 11:17 AM, Bruno Haible wrote: > There are two problems: > > 1) argp-help.c uses STRERROR_R_CHAR_P, which is defined by the macro >AC_FUNC_STRERROR_R, but argp.m4 does not require it (only error.m4 does). > > 2) When the strerror_r-posix module is in place, the results of >A

Re: a bad use of strerror_r

2016-10-26 Thread Bruno Haible
Paul Eggert wrote: > This patch looks good to me. I'll CC: this to Sergey as he's our argp > expert; if he doesn't respond in a few days, please install into gnulib. Haven't heard from Sergey. So I pushed the two patches. Bruno -- Im memoriam Matthias Erzberger

Re: a bad use of strerror_r

2016-10-20 Thread Paul Eggert
This patch looks good to me. I'll CC: this to Sergey as he's our argp expert; if he doesn't respond in a few days, please install into gnulib. Sergey, the patch is here: http://lists.gnu.org/archive/html/bug-gnulib/2016-10/msg00069.html

a bad use of strerror_r

2016-10-16 Thread Bruno Haible
Hi, When I compile a gnulib testdir on a glibc system with "gcc -Wall", I see the following warnings (among others): argp-help.c: In function 'argp_failure': argp-help.c:1878:17: warning: assignment makes pointer from integer without a cast [enabled by default] This is a dangerous one, because