Re: Fix, NSFont, XGFont (was RTFConsumer)

2002-10-10 Thread Fred Kiefer
Most of this patch looks fine for me. What is missing is the special handling now needed for the getNSFont() function. Here we should make sure, that we always return a usefull font. As the only font we can be sure about is the user font in the default size we should return this, if any font

Re: Fix, NSFont, XGFont (was RTFConsumer)

2002-10-10 Thread Georg Fleischmann
Most of this patch looks fine for me. What is missing is the special handling now needed for the getNSFont() function. Here we should make sure, that we always return a usefull font. As the only font we can be sure about is the user font in the default size we should return this, if any

Re: Fix, NSFont, XGFont (was RTFConsumer)

2002-10-10 Thread Nicola Pero
Hi Georg, thanks! I applied your patch. :-) Hi Nicola, Well, here is the long waiting change for NSFont. It's most exactly how you suggested. Looks like [NSFont -initWithName:matrix:] is our own extension, and likely it should return nil if the font can't be found (it now returns

Re: Fix, NSFont, XGFont (was RTFConsumer)

2002-10-10 Thread Nicola Pero
Most of this patch looks fine for me. What is missing is the special handling now needed for the getNSFont() function. Here we should make sure, that we always return a usefull font. As the only font we can be sure about is the user font in the default size we should return this, if

Fix, NSFont, XGFont (was RTFConsumer)

2002-10-09 Thread Georg Fleischmann
Hi Nicola, Well, here is the long waiting change for NSFont. It's most exactly how you suggested. Looks like [NSFont -initWithName:matrix:] is our own extension, and likely it should return nil if the font can't be found (it now returns the default font if I understand correctly). In