bug#24666: converting srfi-18.test to standalone test case for debugging

2016-10-11 Thread Jack Howarth
Does anyone know how to convert the srfi-18.test test case into a standalone one that can be debugged in lldb or gdb? On darwin15, I have confirmed that the thread-local-storage support is causing the failures of... FAIL: srfi-18.test: thread-terminate!: termination destroys non-started

bug#24186: setlocale can't be localised

2016-10-11 Thread Zefram
Ludovic Courtes wrote: >That wouldn't help with the "setlocale" issue you describe per se, but >this would address such use cases in a different way. > >WDYT? Yes, explicit locale objects and locale parameters to relevant functions are a good thing. In general, the model of a global locale state

bug#24186: setlocale can't be localised

2016-10-11 Thread Ludovic Courtès
Hi, Zefram skribis: > (define (call-with-locale cat val body) > (let ((oldval #f)) > (dynamic-wind > (lambda () (set! oldval (setlocale cat)) (setlocale cat val)) > body (lambda () (setlocale cat oldval) > > (define (day-of-week-string) >

bug#22630: Bad comment

2016-10-11 Thread David Kastrup
I routinely rebase before abandoning my patches so it only now caught my attention that this bug fix was committed with changed comments. Unfortunately, one of those comments was changed for the worse. Here is the respective merge conflict: <<< 4f324684cc7672b39800bce0a373da10057dc3c6 /*

bug#24659: 'mkdir' procedure is neither thread-safe nor safe (2.0.12)

2016-10-11 Thread Ludovic Courtès
Hi, skribis: > On Mon, Oct 10, 2016 at 06:39:47PM +0200, Ludovic Courtès wrote: >> Hello! > > [...] > >> Furthermore, AFAICS, the above logic is redundant with what the kernel >> does anyway. That is, in a single-threaded program, >> >> mask = umask (0); >> umask (mask);