bug#35920: strftime incorrectly assumes that nstrftime will produce UTF-8

2019-07-02 Thread John Cowan
On Tue, Jul 2, 2019 at 5:08 AM Ludovic Courtès wrote: I think we should deprecate ‘strftime’ and ‘strptime’: (srfi srfi-19) > provides similar functionality, it uses (ice-9 i18n) for the locale > stuff, and it has a better API. > Just a heads-up. I don't consider SRFI 19 to have a very good API

bug#35920: strftime incorrectly assumes that nstrftime will produce UTF-8

2019-07-02 Thread Ludovic Courtès
Hi Mark, Mark H Weaver skribis: >> Mark H Weaver skribis: >> >>> Here's a patch that might fix the problem, but I don't have time to test >>> it right now. >> >> It works! :-) I wrote tests and pushed it as >> ab2fd70ef1e36c6532128b73082809ef3c056556. > > On my system, I found that my proposed

bug#35920: strftime incorrectly assumes that nstrftime will produce UTF-8

2019-07-02 Thread Ludovic Courtès
Hi, Mark H Weaver skribis: > John Cowan writes: > >> That's a mug's game: I've been there and tried it (not in Scheme). I >> recommend writing a strftime in Scheme from scratch. It's not that >> hard; the most annoying thing is getting into the locale files to >> handle the locale-sensitive di

bug#35920: strftime incorrectly assumes that nstrftime will produce UTF-8

2019-06-30 Thread John Cowan
On Sun, Jun 30, 2019 at 7:06 PM Mark H Weaver wrote: Is there a portable way to find the relevant locale files and interpret > them, on both POSIX and Windows systems? If so, can you point out the > relevant documentation? > Portable in the sense that the information can be obtained on both Pos

bug#35920: strftime incorrectly assumes that nstrftime will produce UTF-8

2019-06-30 Thread Mark H Weaver
Hi John, John Cowan writes: > That's a mug's game: I've been there and tried it (not in Scheme). I > recommend writing a strftime in Scheme from scratch. It's not that > hard; the most annoying thing is getting into the locale files to > handle the locale-sensitive directives (month name, weekd

bug#35920: strftime incorrectly assumes that nstrftime will produce UTF-8

2019-06-30 Thread John Cowan
That's a mug's game: I've been there and tried it (not in Scheme). I recommend writing a strftime in Scheme from scratch. It's not that hard; the most annoying thing is getting into the locale files to handle the locale-sensitive directives (month name, weekday name, AM/PM, and the ordering of dat

bug#35920: strftime incorrectly assumes that nstrftime will produce UTF-8

2019-06-30 Thread Mark H Weaver
reopen 35920 thanks Hi Ludovic, > Mark H Weaver skribis: > >> Here's a patch that might fix the problem, but I don't have time to test >> it right now. > > It works! :-) I wrote tests and pushed it as > ab2fd70ef1e36c6532128b73082809ef3c056556. On my system, I found that my proposed patch caus

bug#35920: strftime incorrectly assumes that nstrftime will produce UTF-8

2019-06-30 Thread Ludovic Courtès
Hi Mark, Mark H Weaver skribis: > Here's a patch that might fix the problem, but I don't have time to test > it right now. It works! :-) I wrote tests and pushed it as ab2fd70ef1e36c6532128b73082809ef3c056556. I forgot to change the commit author to you before pushing, apologies! Thanks, Lud

bug#35920: strftime incorrectly assumes that nstrftime will produce UTF-8

2019-05-26 Thread Christopher Lam
Thanks! I'm glad to know this. I have adequate fluency in guile now but very basic C hence some bugs are very opaque to me. On Mon., 27 May 2019, 04:43 Mark H Weaver, wrote: > Hi Christopher, > > Christopher Lam writes: > > > Addendum - wish to confirm if guile bug (guile-2.2 on Windows): > > -

bug#35920: strftime incorrectly assumes that nstrftime will produce UTF-8

2019-05-26 Thread Mark H Weaver
Here's a patch that might fix the problem, but I don't have time to test it right now. Mark --8<---cut here---start->8--- diff --git a/libguile/stime.c b/libguile/stime.c index b681d7ee3..9a21b61fe 100644 --- a/libguile/stime.c +++ b/libguile/stime.c @@

bug#35920: strftime incorrectly assumes that nstrftime will produce UTF-8

2019-05-26 Thread Mark H Weaver
There might also be related problems with 'strptime'. These problems date back to when Guile was first extended to support non-ASCII strings. Here's the relevant commit in 2009 that added non-ASCII support to 'strftime' and 'strptime', but did so imperfectly: 587a33556fdef90025c1b7d4d172af649c8ebb

bug#35920: strftime incorrectly assumes that nstrftime will produce UTF-8

2019-05-26 Thread Mark H Weaver
Hi Christopher, Christopher Lam writes: > Addendum - wish to confirm if guile bug (guile-2.2 on Windows): > - set locale to non-Anglo so that (setlocale LC_ALL) returns > "French_France.1252" > - call (strftime "%B" 400) - that's 4x10^6 -- this should return > "février 1970" > > but the foll