Hi,
Maxim Cournoyer writes:
> I was recently reminded of this bug by a new encounter; at last wrote a
> test for your proposed fix, and it appear to work as intended! I've
> committed it on your behalf in commit 485ac28235 on the core-updates
> branch.
Thanks for taking care of this Maxim, and
Hello Mark,
I was recently reminded of this bug by a new encounter; at last wrote a
test for your proposed fix, and it appear to work as intended! I've
committed it on your behalf in commit 485ac28235 on the core-updates
branch.
Closing!
Thank you for the clever hack :-)
Maxim
Hi Maxim,
Maxim Cournoyer writes:
> Mark H Weaver writes:
>
>> With the changes suggested above, I would have no objection to pushing
>> this to core-updates. However, it occurs to me that we could handle the
>> NUL case in a better way:
>>
>> Since the C regex functions that we use cannot han
Hi Mark,
Mark H Weaver writes:
> Hi Maxim,
>
> Thanks for working on this. I found a problem with this patch,
> and I also have a suggestion. Please see below.
>
> Maxim Cournoyer writes:
>
>> From 9891e428eae0ed24e0d61862b3f5e298606b79eb Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer
>>
Mark H Weaver skribis:
> Thanks for working on this. I found a problem with this patch,
> and I also have a suggestion. Please see below.
I hadn’t seen Mark’s reply, which raises valid concerns. Please dismiss
the message I just sent, Maxim.
Ludo’.
Hello Maxim,
Maxim Cournoyer skribis:
> l...@gnu.org (Ludovic Courtès) writes:
[...]
>> Otherwise LGTM. This would have to go to the next ‘core-updates’ (or
>> ‘core-updates-next’ in the meantime.)
>>
>> Thanks!
>>
>> Ludo’.
>
> Ping. Is it the right time to merge this?
Yes you can push it t
Hi Maxim,
Thanks for working on this. I found a problem with this patch,
and I also have a suggestion. Please see below.
Maxim Cournoyer writes:
> From 9891e428eae0ed24e0d61862b3f5e298606b79eb Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer
> Date: Sun, 14 Jan 2018 20:31:33 -0500
> Subject:
l...@gnu.org (Ludovic Courtès) writes:
> Maxim Cournoyer skribis:
>
>> From 9891e428eae0ed24e0d61862b3f5e298606b79eb Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer
>> Date: Sun, 14 Jan 2018 20:31:33 -0500
>> Subject: [PATCH] utils: Prevent substitute from crashing on files containing
>> NUL
Maxim Cournoyer skribis:
> l...@gnu.org (Ludovic Courtès) writes:
>
>> Maxim Cournoyer skribis:
>>
>>> In the `patch-el-files' phase of the emacs-build-system, we find the
>>> following snippet:
>>>
>>> (with-directory-excursion el-dir
>>> ;; Some old '.el' files (e.g., tex-buf.el in A
l...@gnu.org (Ludovic Courtès) writes:
> Maxim Cournoyer skribis:
>
>> In the `patch-el-files' phase of the emacs-build-system, we find the
>> following snippet:
>>
>> (with-directory-excursion el-dir
>> ;; Some old '.el' files (e.g., tex-buf.el in AUCTeX) are still encoded
>> ;;
Maxim Cournoyer skribis:
> In the `patch-el-files' phase of the emacs-build-system, we find the
> following snippet:
>
> (with-directory-excursion el-dir
> ;; Some old '.el' files (e.g., tex-buf.el in AUCTeX) are still encoded
> ;; with the "ISO-8859-1" locale.
> (unless (fa
l...@gnu.org (Ludovic Courtès) writes:
> Mark H Weaver skribis:
>
>> Maxim Cournoyer writes:
>>
>>> l...@gnu.org (Ludovic Courtès) writes:
>>>
Maxim Cournoyer skribis:
> I've encountered the following crash when trying to use substitute on a
> file which contains NUL character
Mark H Weaver skribis:
> Maxim Cournoyer writes:
>
>> l...@gnu.org (Ludovic Courtès) writes:
>>
>>> Maxim Cournoyer skribis:
>>>
I've encountered the following crash when trying to use substitute on a
file which contains NUL characters:
>>>
>>> Yes, that’s because Guile’s ‘regexp-exec
Maxim Cournoyer writes:
> l...@gnu.org (Ludovic Courtès) writes:
>
>> Maxim Cournoyer skribis:
>>
>>> I've encountered the following crash when trying to use substitute on a
>>> file which contains NUL characters:
>>
>> Yes, that’s because Guile’s ‘regexp-exec’ simply wraps libc’s ‘regexec’,
>>
l...@gnu.org (Ludovic Courtès) writes:
> Hi,
>
> Maxim Cournoyer skribis:
>
>> I've encountered the following crash when trying to use substitute on a
>> file which contains NUL characters:
>
> Yes, that’s because Guile’s ‘regexp-exec’ simply wraps libc’s ‘regexec’,
> which does not handle NULs.
Maxim Cournoyer skribis:
> From 9891e428eae0ed24e0d61862b3f5e298606b79eb Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer
> Date: Sun, 14 Jan 2018 20:31:33 -0500
> Subject: [PATCH] utils: Prevent substitute from crashing on files containing
> NUL chars.
>
> Fixes issue #30116.
>
> * guix/build/
Hi,
Maxim Cournoyer skribis:
> I've encountered the following crash when trying to use substitute on a
> file which contains NUL characters:
Yes, that’s because Guile’s ‘regexp-exec’ simply wraps libc’s ‘regexec’,
which does not handle NULs.
We should consider switching to the pure-Scheme SRFI
>From 9891e428eae0ed24e0d61862b3f5e298606b79eb Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer
Date: Sun, 14 Jan 2018 20:31:33 -0500
Subject: [PATCH] utils: Prevent substitute from crashing on files containing
NUL chars.
Fixes issue #30116.
* guix/build/utils.scm (substitute): Add condition to s
Hello,
I've encountered the following crash when trying to use substitute on a
file which contains NUL characters:
--8<---cut here---start->8---
(define problematic-file "/tmp/bp-image-data.el")
scheme@(guix build utils)> ,m (guix build utils)
scheme@(guix buil
19 matches
Mail list logo
