bug#35542: Installer does not display full backtrace on error

2019-05-15 Thread Mathieu Othacehe
Hey, > I think 200 is good. You wouldn’t want the backtrace to be filled with > bytevectors, for instance. Fine with me. Pushed. Thanks for reviewing, Mathieu

bug#35542: Installer does not display full backtrace on error

2019-05-14 Thread Ludovic Courtès
Hi Mathieu, Mathieu Othacehe skribis: >> That would ensure we’re only changing Guile’s notion of the terminal >> width and not interfering with other tools we might launch as child >> processes. >> >> Thoughts? > > Seems like a better idea indeed. Here's an update patch. > > About using 200 or a

bug#35542: Installer does not display full backtrace on error

2019-05-14 Thread Danny Milosavljevic
Hi Mathieu, On Sat, 04 May 2019 11:43:28 +0200 Mathieu Othacehe wrote: > Hello, > > > I believe I read about Guile error messages not doing line wrapping in > > terminals on the Guix or Guile mailing lists recently, but I cannot > > find it. Proper line wrapping may be the better solution. >

bug#35542: Installer does not display full backtrace on error

2019-05-14 Thread Mathieu Othacehe
Hey Ludo, > That would ensure we’re only changing Guile’s notion of the terminal > width and not interfering with other tools we might launch as child > processes. > > Thoughts? Seems like a better idea indeed. Here's an update patch. About using 200 or a much larger value as Danny suggested, I

bug#35542: Installer does not display full backtrace on error

2019-05-08 Thread Ludovic Courtès
Hi Mathieu, Mathieu Othacehe skribis: > + ;; Initialize 'terminal-width' in (system repl debug) > + ;; to a large-enough value to make backtrace more > + ;; verbose. > + (setenv "COLUMNS" "200") What about instead doing something like this: (use-modules ((system repl

bug#35542: Installer does not display full backtrace on error

2019-05-04 Thread pelzflorian (Florian Pelz)
On Sat, May 04, 2019 at 07:38:07PM +0200, pelzflorian (Florian Pelz) wrote: > On Sat, May 04, 2019 at 07:06:17PM +0200, Danny Milosavljevic wrote: > > So I'd be for either presenting the entire backtrace or suppressing the > > entire backtrace, not having teaser backtraces :) > > Let’s assume some

bug#35542: Installer does not display full backtrace on error

2019-05-04 Thread pelzflorian (Florian Pelz)
On Sat, May 04, 2019 at 07:06:17PM +0200, Danny Milosavljevic wrote: > So I'd be for either presenting the entire backtrace or suppressing the > entire backtrace, not having teaser backtraces :) Let’s assume someone is getting an error in the installer for some reason. If they are Guix developers

bug#35542: Installer does not display full backtrace on error

2019-05-04 Thread pelzflorian (Florian Pelz)
On Sat, May 04, 2019 at 06:14:48PM +0200, Mathieu Othacehe wrote: > Thanks for testing Florian. Based on Danny suggestion we could set > COLUMNS to 200 to have a more verbose backtrace (like guix itself). > It works (I have applied both patches). This is one of the longer backtrace steps: In ic

bug#35542: Installer does not display full backtrace on error

2019-05-04 Thread Danny Milosavljevic
Hi Mathieu, On Sat, 04 May 2019 18:14:48 +0200 Mathieu Othacehe wrote: > Thanks for testing Florian. Based on Danny suggestion we could set > COLUMNS to 200 to have a more verbose backtrace (like guix itself). Good idea in principle. > Using higher values, the backtrace becomes really long and

bug#35542: Installer does not display full backtrace on error

2019-05-04 Thread Mathieu Othacehe
And the patch ... Sorry, Mathieu >From 3348df0c72e9bcdf31b63155d9c6bdbaee515524 Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Sat, 4 May 2019 18:10:40 +0200 Subject: [PATCH] installer: Increase backtrace verbosity. * gnu/installer.scm (installer-program): Set COLUMNS env variable to 20

bug#35542: Installer does not display full backtrace on error

2019-05-04 Thread Mathieu Othacehe
Hey, > ,use (system repl debug) ; or #:use-module (system repl debug) > (terminal-width 200) > > f.e. at the top of gnu/installer.scm Thanks for testing Florian. Based on Danny suggestion we could set COLUMNS to 200 to have a more verbose backtrace (like guix itself). Using higher values,

bug#35542: Installer does not display full backtrace on error

2019-05-04 Thread Danny Milosavljevic
Hi, On Sat, 4 May 2019 14:24:03 +0200 "pelzflorian (Florian Pelz)" wrote: > I now get linewrapping, but provoked errors (these are not new bugs!) > are cut off like > > In ./gnu/installer/keymap.scm > 163:7 8 (_ _) > In unknown file: >7 (scm-error misc-error #f "~A" ("Unable to

bug#35542: Installer does not display full backtrace on error

2019-05-04 Thread pelzflorian (Florian Pelz)
On Sat, May 04, 2019 at 11:43:28AM +0200, Mathieu Othacehe wrote: > Hello, > > > I believe I read about Guile error messages not doing line wrapping in > > terminals on the Guix or Guile mailing lists recently, but I cannot > > find it. Proper line wrapping may be the better solution. > > In fac

bug#35542: Installer does not display full backtrace on error

2019-05-04 Thread Mathieu Othacehe
Hello, > I believe I read about Guile error messages not doing line wrapping in > terminals on the Guix or Guile mailing lists recently, but I cannot > find it. Proper line wrapping may be the better solution. In fact the textbox where the backtrace is displayed isn't doing any line wrapping. Th

bug#35542: Installer does not display full backtrace on error

2019-05-03 Thread pelzflorian (Florian Pelz)
On Fri, May 03, 2019 at 02:15:27PM +0200, Mathieu Othacehe wrote: > > Hey, > > > Not sure if this can be fixed. Mathieu? > > The textbox object used for the backtrace window only supports vertical > scrolling. However, the text should be broken in lines that fit the box > horizontally, I'll try

bug#35542: Installer does not display full backtrace on error

2019-05-03 Thread Mathieu Othacehe
Hey, > Not sure if this can be fixed. Mathieu? The textbox object used for the backtrace window only supports vertical scrolling. However, the text should be broken in lines that fit the box horizontally, I'll try to find why it doesn't work. Mathieu

bug#35542: Installer does not display full backtrace on error

2019-05-03 Thread Ludovic Courtès
"pelzflorian (Florian Pelz)" skribis: > When the Newt installer displays a backtrace, it is possible to scroll > up and down, but not left and right. This cuts off important error > messages. Not sure if this can be fixed. Mathieu? The backtrace is kept in /tmp though. Ludo'.

bug#35542: Installer does not display full backtrace on error

2019-05-03 Thread Danny Milosavljevic
On Fri, 3 May 2019 10:59:27 +0200 "pelzflorian (Florian Pelz)" wrote: > When the Newt installer displays a backtrace, it is possible to scroll > up and down, but not left and right. This cuts off important error > messages. IMO the better solution would be to wrap the text--and not to add anoth

bug#35542: Installer does not display full backtrace on error

2019-05-03 Thread pelzflorian (Florian Pelz)
When the Newt installer displays a backtrace, it is possible to scroll up and down, but not left and right. This cuts off important error messages.