Ok, sounds good to me. :)
Liliana Marie Prikler writes:
> Hi Roman,
>
> Am Sonntag, dem 20.03.2022 um 14:58 +0100 schrieb Roman Scherer:
>> Hi Liliana and Maxime,
>>
>> if the icons are really coming from [1], they seem to be licensed
>> under the Creative Commons Attribution 4.0 International
Hi Roman,
Am Sonntag, dem 20.03.2022 um 14:58 +0100 schrieb Roman Scherer:
> Hi Liliana and Maxime,
>
> if the icons are really coming from [1], they seem to be licensed
> under the Creative Commons Attribution 4.0 International Public
> License.
>
> If it is okay to include them, I could work
Hi Liliana and Maxime,
if the icons are really coming from [1], they seem to be licensed under
the Creative Commons Attribution 4.0 International Public License.
If it is okay to include them, I could work on a patch that only
installs the VS Code icons. I think we need to give credit and link
Hi Roman,
Am Sonntag, dem 20.03.2022 um 12:21 +0100 schrieb Roman Scherer:
>
> Hi Liliana,
>
> thanks for adding the comment locally. I just checked the source of
> LSP Treemacs and yes, they are all mentioned by name here:
>
>
Hi Liliana,
thanks for adding the comment locally. I just checked the source of LSP
Treemacs and yes, they are all mentioned by name here:
https://github.com/emacs-lsp/lsp-treemacs/blob/master/lsp-treemacs-themes.el#L38
Is this a problem? Should the build script remove them?
If that's the
Hi Roman, hi Maxime,
Am Sonntag, dem 20.03.2022 um 11:35 +0100 schrieb Roman Scherer:
> Hi Maxime,
>
> ok, I see. Thanks for the explanation. I attached a patch that
> removes the icons from the source as per your suggestion.
>
> What do you think about this one?
>
> Thanks, Roman.
The logic
Hi Maxime,
ok, I see. Thanks for the explanation. I attached a patch that removes
the icons from the source as per your suggestion.
What do you think about this one?
Thanks, Roman.
From 5468ef15c239133366314d0d5131e440c2e8893f Mon Sep 17 00:00:00 2001
From: r0man
Date: Sat, 19 Mar 2022
Roman Scherer schreef op zo 20-03-2022 om 09:59 [+0100]:
> Since the icons are not installed on a Guix system right now, I think
> we can leave the Guix emacs-lsp-treemacs packages as it is for now.
>
> Once upstream has added the licenses for the icons, we could take
> another look and maybe
Hi Maxime,
thanks for taking a look at my patch and uncovering this license
issue. I was not aware of that.
When I said the emacs-lsp-treemacs package is not bundling it's icons, I
meant that the Guix emacs-lsp-treemacs package does not install them.
So, without my patch, I see the following
Roman Scherer schreef op za 19-03-2022 om 16:29 [+0100]:
> the emacs-lsp-treemacs package does not bundle it's icons. This patch
> fixes the issue by copying the icons to `share/emacs-lsp-
> treemacs/icons` and patching the paths in `lsp-treemacs-themes.el`.
That might technically solves matter,
Hello,
the emacs-lsp-treemacs package does not bundle it's icons. This patch
fixes the issue by copying the icons to `share/emacs-lsp-treemacs/icons`
and patching the paths in `lsp-treemacs-themes.el`.
This is the link to the issue in bug tracker: https://issues.guix.gnu.org/50329
Would you
11 matches
Mail list logo
