bug#56297: Guix style imperfections

2022-07-19 Thread Maxime Devos
Ludovic Courtès schreef op ma 04-07-2022 om 23:41 [+0200]: > > Commit 8d9291bd2c36810be50ea340cefa481a42c60a2b fixes this [...] Some issues remain, but nice!

bug#56297: Guix style imperfections

2022-07-04 Thread Ludovic Courtès
Hi, Ludovic Courtès skribis: >>> (define-public guile-next >>> (let ((version "3.0.7") (revision "0") >>>(commit "d70c1dbebf9ac0fd45af4578c23983ec4a7da535")) >> >> Conventionally 'revision' is put on another line -- for these kind of let >> bindings, >> (maybe all?), I would recommend

bug#56297: Guix style imperfections

2022-07-02 Thread Ludovic Courtès
Hi, Maxime Devos skribis: > "guix style" occasionally makes some decision that seem a bit > questionable to me. Let’s keep in mind that some are bugs/limitations that can be fixed, while others cannot really be addressed because our tastes vary depending on context and the pretty printer could

bug#56297: Guix style imperfections

2022-06-29 Thread Liliana Marie Prikler
Am Mittwoch, dem 29.06.2022 um 12:18 +0200 schrieb Maxime Devos: > Liliana Marie Prikler schreef op wo 29-06-2022 om 12:15 [+0200]: > > Here, it depends.  I think I'd write this as > > > > (native-inputs  > >    (modify-inputs (package-native-inputs guile-3.0) > > (prepend

bug#56297: Guix style imperfections

2022-06-29 Thread Liliana Marie Prikler
Am Mittwoch, dem 29.06.2022 um 12:19 +0200 schrieb Maxime Devos: > Liliana Marie Prikler schreef op wo 29-06-2022 om 12:15 [+0200]: > > > >     (delete-file > > > > "test- > > > > suite/tests/version.test") > > > > #t)) > > >

bug#56297: Guix style imperfections

2022-06-29 Thread Maxime Devos
Liliana Marie Prikler schreef op wo 29-06-2022 om 12:15 [+0200]: > > >     (delete-file > > > "test- > > > suite/tests/version.test") > > > #t)) > > > > (Would be nice if "guix style" could be taught to remove those #t, > >

bug#56297: Guix style imperfections

2022-06-29 Thread Maxime Devos
Liliana Marie Prikler schreef op wo 29-06-2022 om 12:15 [+0200]: > Here, it depends.  I think I'd write this as > > (native-inputs  >    (modify-inputs (package-native-inputs guile-3.0) > (prepend autoconf automake libtool >   flex gperf >  

bug#56297: Guix style imperfections

2022-06-29 Thread Liliana Marie Prikler
Am Mittwoch, dem 29.06.2022 um 11:33 +0200 schrieb Maxime Devos: > Hi, > > "guix style" occasionally makes some decision that seem a bit > questionable to me.  More concretely, copy the definition of guile- > next, put it in a .scm and rename it, and run > "guix style -L . guile-next-styleme".  I

bug#56297: Guix style imperfections

2022-06-29 Thread Maxime Devos
Hi, "guix style" occasionally makes some decision that seem a bit questionable to me. More concretely, copy the definition of guile- next, put it in a .scm and rename it, and run "guix style -L . guile-next-styleme". I get: > (define-module (test)) > (use-modules (guix packages) (guix