bug#57232: [installer] ENTER in guided partitioner destroys partition table

2022-10-13 Thread Mathieu Othacehe
Hey, > Fixes: . > > * gnu/installer/newt/partition.scm (run-label-confirmation-page): New > procedure. > (run-label-page): Call the above procedure before proceeding. I pushed a slightly edited version of this patch. Thanks, Mathieu

bug#57232: [installer] ENTER in guided partitioner destroys partition table

2022-08-16 Thread Tobias Geerinckx-Rice via Bug reports for GNU Guix
Hi Mathieu, Mathieu Othacehe 写道: Er, I was… expecting that to mean it would pop up a pretty window or something. Is this really a feature? Should it be? I'm not sure what's the point here. I'm not sure whose point you're referring to, so I'll clarify mine. Currently, pressing ENTER on

bug#57232: [installer] ENTER in guided partitioner destroys partition table

2022-08-16 Thread Mathieu Othacehe
Hey, > “You can change a disk's partition table by selecting it and pressing > ENTER.” > > Er, I was… expecting that to mean it would pop up a pretty window or > something. Is this really a feature? Should it be? I'm not sure what's the point here. > I have to be honest: I was extremely

bug#57232: [installer] ENTER in guided partitioner destroys partition table

2022-08-16 Thread Tobias Geerinckx-Rice via Bug reports for GNU Guix
Hi Mathieu! Mathieu Othacehe 写道: What that does is immediately and without confirmation wipe the on-disc partition table. And its back-up. Oops, glad you were able to recover, I was also bitten in the past. My mistake for insisting on a bare metal test without a throwaway machine handy

bug#57232: [installer] ENTER in guided partitioner destroys partition table

2022-08-16 Thread Mathieu Othacehe
Hey Tobias, > What that does is immediately and without confirmation wipe the on-disc > partition table. And its back-up. Oops, glad you were able to recover, I was also bitten in the past. The attached patch adds an extra confirmation page before wiping everything, WDYT? Mathieu >From

bug#57232: [installer] ENTER in guided partitioner destroys partition table

2022-08-15 Thread Tobias Geerinckx-Rice via Bug reports for GNU Guix
Hi all, Whilst testing the graphical installer, I selected ‘guided partitioning’ and pressed ENTER on the main drive (sda) to see what that does. What that does is immediately and without confirmation wipe the on-disc partition table. And its back-up. Testdisk is great, T G-R