bug#39511: github auth

[Maxim Cournoyer]

Ludovic Courtès  writes:

> Hi Matt,
>
> Matt Wette  skribis:
>
>> I have not gotten into testing, but according to email and references
>> provided previously the patch below might work.
>
> I’ve applied the patch on your behalf, thank you!
>
> Ludo’.

Closing, thanks!

Maxim

bug#39511: github auth

[Matt Wette]

On 2/22/20 2:52 AM, Ludovic Courtès wrote:

Hi Matt,

Matt Wette  skribis:


I have not gotten into testing, but according to email and references
provided previously the patch below might work.

I’ve applied the patch on your behalf, thank you!

Ludo’.



much appreciated

Matt

bug#39511: github auth

[Ludovic Courtès]

Hi Matt,

Matt Wette  skribis:

> I have not gotten into testing, but according to email and references
> provided previously the patch below might work.

I’ve applied the patch on your behalf, thank you!

Ludo’.

bug#39511: github auth

[Matt Wette]

I have not gotten into testing, but according to email and references
provided previously the patch below might work.


--- github.scm-orig    2020-02-15 10:32:52.209481329 -0800
+++ github.scm    2020-02-15 10:40:36.958144491 -0800
@@ -154,14 +154,12 @@
 ;; Ask for version 3 of the API as suggested at
 ;; .
 `((Accept . "application/vnd.github.v3+json")
+  ,@(if (%github-token)
+    `(Authorization . ,(string-append "token " (%github-token)))
+    '())
   (user-agent . "GNU Guile")))

-  (define (decorate url)
-    (if (%github-token)
-    (string-append url "?access_token=" (%github-token))
-    url))
-
-  (match (json-fetch (decorate release-url) #:headers headers)
+  (match (json-fetch release-url #:headers headers)
 (#()
  ;; We got the empty list, presumably because the user didn't use 
GitHub's

  ;; "release" mechanism, but hopefully they did use Git tags.