bug#63378: [PATCH] teams: Fix script to produce a single X-Debbugs-Cc header.

2023-05-11 Thread Arun Isaac
> It's string-contains without ?, apparently. Ah, yes. That one always trips me up. > The change is now installed; thanks for the review! Thank you! :-)

bug#63378: [PATCH] teams: Fix script to produce a single X-Debbugs-Cc header.

2023-05-11 Thread Maxim Cournoyer
Hi Arun, Arun Isaac writes: > Hi Maxim, > > Thank you for the updated patch! :-) It LGTM. Please push. > >> OK! I opted for simplicity and double-quoted all the names. > > Fair enough. Though a check is only one condition away! ;-) > > (if (string-contains? (person-name member) ",") >

bug#63378: [PATCH] teams: Fix script to produce a single X-Debbugs-Cc header.

2023-05-11 Thread Arun Isaac
Hi Maxim, Thank you for the updated patch! :-) It LGTM. Please push. > OK! I opted for simplicity and double-quoted all the names. Fair enough. Though a check is only one condition away! ;-) (if (string-contains? (person-name member) ",") (string-append "\"" (person-name member) "\"")

bug#63378: [PATCH] teams: Fix script to produce a single X-Debbugs-Cc header.

2023-05-10 Thread Maxim Cournoyer
Hi Arun, Arun Isaac writes: > Hi Maxim, > > When a patch relates to no teams, I get the empty header output > "X-Debbugs-Cc: ". For such patches, it would be nicer to not add any > header instead of adding an empty header. Good catch! Fixed. >> +(define (team->members team) >> + "Return the

bug#63378: [PATCH] teams: Fix script to produce a single X-Debbugs-Cc header.

2023-05-09 Thread Arun Isaac
Hi Maxim, When a patch relates to no teams, I get the empty header output "X-Debbugs-Cc: ". For such patches, it would be nicer to not add any header instead of adding an empty header. > +(define (team->members team) > + "Return the list of members in TEAM." > + (sort (team-members team) > +

bug#63378: [PATCH] teams: Fix script to produce a single X-Debbugs-Cc header.

2023-05-08 Thread Maxim Cournoyer
Fixes . * etc/teams.scm.in (cc): Adjust format pattern. (team->members, member->string): New procedures. (list-members): Refactor in terms of the above procedures. (main): Adjust the output of the 'cc-members-header-cmd' and 'cc-mentors-header-cmd' actions. ---