bug#37421: [PATCH] gnu: node: Disable tests that fail with openssl@1.1.1d.

[Jelle Licht]

Tobias Geerinckx-Rice  writes:

> Ludovic Courtès 写道：
>> Could we take a look at what these failures are about to see how 
>> bad
>> that might be?
>
> Jelle Licht 写道：
>> Interestingly enough, https://github.com/nodejs/node/issues/3881 
>> notes
>> issues with exactly these two tests. Perhaps there is a 
>> regressions in
>> our case?
>
> Thanks, and indeed!  That is _quite_ the coincidence…
>
> Unfortunately, I don't see any mention of a time-out in my logs & 
> the truncation of the backtrace
>
>   at Object. (…/test/parallel/test-crypto-dh.js:124:8)
>   at Module._compile (internal/modules/cjs/loader.js:701:30)
>   at Object.Module._extensions..js 
>   (internal/modules/cjs/loader.js:712:10)
>   at Module.load (internal/modules/cjs/loader.js:600:32)
>   at tryModuleLoad (internal/modules/cjs/loader.js:539:12)
>   at Function.Module._load (internal/modules/cjs/loader.js:531:3)
>   at Function.Module.runMain 
>   (internal/modules/cjs/loader.js:754:12)
>   at startup (internal/bootstrap/node.js:283:19)
>   at bootstrapNodeJSCore (internal/bootstrap/node.js:622:3)
>   ...
>
> happens at run time: grepping the output of ‘--keep’ doesn't 
> reveal a more complete one :-(
>
> I don't know how to hack the tests to spit out more.  Someone who 
> knows node/js more than I do needs to step in and save us.  Is 
> that you, Jelle? :-)

I believe in learning by doing, so I'll have a go at it somewhere early
next week :-).

For now, I think it makes sense to push this patch so we can have a
(hopefully) working and secure ungoogled-chromium.

>
> Kind regards,
>
> T G-R

bug#37421: [PATCH] gnu: node: Disable tests that fail with openssl@1.1.1d.

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

Ludovic Courtès 写道：
Could we take a look at what these failures are about to see how 
bad

that might be?


Jelle Licht 写道：
Interestingly enough, https://github.com/nodejs/node/issues/3881 
notes
issues with exactly these two tests. Perhaps there is a 
regressions in

our case?


Thanks, and indeed!  That is _quite_ the coincidence…

Unfortunately, I don't see any mention of a time-out in my logs & 
the truncation of the backtrace


 at Object. (…/test/parallel/test-crypto-dh.js:124:8)
 at Module._compile (internal/modules/cjs/loader.js:701:30)
 at Object.Module._extensions..js 
 (internal/modules/cjs/loader.js:712:10)

 at Module.load (internal/modules/cjs/loader.js:600:32)
 at tryModuleLoad (internal/modules/cjs/loader.js:539:12)
 at Function.Module._load (internal/modules/cjs/loader.js:531:3)
 at Function.Module.runMain 
 (internal/modules/cjs/loader.js:754:12)

 at startup (internal/bootstrap/node.js:283:19)
 at bootstrapNodeJSCore (internal/bootstrap/node.js:622:3)
 ...

happens at run time: grepping the output of ‘--keep’ doesn't 
reveal a more complete one :-(


I don't know how to hack the tests to spit out more.  Someone who 
knows node/js more than I do needs to step in and save us.  Is 
that you, Jelle? :-)


Kind regards,

T G-R


signature.asc
Description: PGP signature

bug#37421: [PATCH] gnu: node: Disable tests that fail with openssl@1.1.1d.

[Jelle Licht]

Ludovic Courtès  writes:

> Hello,
>
> Tobias Geerinckx-Rice via Bug reports for GNU Guix 
> skribis:
>
>> Work around .
>>
>> * gnu/packages/node.scm (node)[arguments]: Disable failing tests.
>
> [...]
>
>> + ;; FIXME: These tests fail with openssl@1.1.1d.
>> + (for-each delete-file
>> +   '("test/parallel/test-crypto-binary-default.js"
>> + "test/parallel/test-crypto-dh.js"))
>
> It may be the best short-term solution.
Agreed, if ungoogled-chromium works with this that would probably be the
best option.
>
> Could we take a look at what these failures are about to see how bad
> that might be?

Interestingly enough, https://github.com/nodejs/node/issues/3881 notes
issues with exactly these two tests. Perhaps there is a regressions in
our case?

bug#37421: [PATCH] gnu: node: Disable tests that fail with openssl@1.1.1d.

[Ludovic Courtès]

Hello,

Tobias Geerinckx-Rice via Bug reports for GNU Guix 
skribis:

> Work around .
>
> * gnu/packages/node.scm (node)[arguments]: Disable failing tests.

[...]

> + ;; FIXME: These tests fail with openssl@1.1.1d.
> + (for-each delete-file
> +   '("test/parallel/test-crypto-binary-default.js"
> + "test/parallel/test-crypto-dh.js"))

It may be the best short-term solution.

Could we take a look at what these failures are about to see how bad
that might be?

Thanks,
Ludo’.

bug#37421: [PATCH] gnu: node: Disable tests that fail with openssl@1.1.1d.

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

Work around .

* gnu/packages/node.scm (node)[arguments]: Disable failing tests.
---

Jelle, Guix,

So here's the obvious non-solution, ignoring test failures being the lesser 
evil compared to 4 potential CVEs anywhere in a Web browser's closure.

It seems to ‘work’ in a short VM Chromium test.  As in, nothing broke.  Don't 
know how to test Node.  Thoughts?

Kind regards,

T G-R

 gnu/packages/node.scm | 5 +
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index fc43fcb04c..f467be7665 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -91,6 +91,11 @@
  (add-before 'configure 'patch-files
(lambda* (#:key inputs #:allow-other-keys)
 
+ ;; FIXME: These tests fail with openssl@1.1.1d.
+ (for-each delete-file
+   '("test/parallel/test-crypto-binary-default.js"
+ "test/parallel/test-crypto-dh.js"))
+
  ;; Fix hardcoded /bin/sh references.
  (substitute* '("lib/child_process.js"
 "lib/internal/v8_prof_polyfill.js"
-- 
2.23.0