Re: hello-2.11 fails multibyte-1 and atexit-1 on musl

2022-01-31 Thread Reuben Thomas
On Mon, 31 Jan 2022 at 18:43, Reuben Thomas wrote: > > Thanks! I'll make a new release. I've released 2.12. -- https://rrt.sc3d.org

Re: hello-2.11 fails multibyte-1 and atexit-1 on musl

2022-01-31 Thread Reuben Thomas
On Mon, 31 Jan 2022 at 18:37, Sergei Trofimovich wrote: > Your varian of atext-1 works on musl for me. Thank you! Thanks! I'll make a new release. -- https://rrt.sc3d.org

Re: hello-2.11 fails multibyte-1 and atexit-1 on musl

2022-01-31 Thread Sergei Trofimovich
On Mon, 31 Jan 2022 11:39:47 + Reuben Thomas wrote: > Thanks very much for the analysis and suggested patch. > > I don't think however that a code change is needed. Arguably, the > correct fix would be to check the return value of wprintf, but in fact > close_stdout() already checks if

Re: hello-2.11 fails multibyte-1 and atexit-1 on musl

2022-01-31 Thread Reuben Thomas
Thanks very much for the analysis and suggested patch. I don't think however that a code change is needed. Arguably, the correct fix would be to check the return value of wprintf, but in fact close_stdout() already checks if there was a previous error on the stream. I think that arbitrarily

Re: hello-2.11 fails multibyte-1 and atexit-1 on musl

2022-01-29 Thread Sergei Trofimovich
On Thu, 27 Jan 2022 22:08:57 + Reuben Thomas wrote: > On Wed, 26 Jan 2022 at 12:59, Sergei Trofimovich wrote: > > > > Thanks for the report! > > > From what I understand at > > > > https://wiki.musl-libc.org/functional-differences-from-glibc.html#Character-sets-and-locale > > musl

Re: hello-2.11 fails multibyte-1 and atexit-1 on musl

2022-01-27 Thread Reuben Thomas
On Wed, 26 Jan 2022 at 12:59, Sergei Trofimovich wrote: > Thanks for the report! > From what I understand at > > https://wiki.musl-libc.org/functional-differences-from-glibc.html#Character-sets-and-locale > musl deliberately supports any char -> wchar_t (and back) conversion for > any char