[PATCH] add missing format strings

2011-10-18 Thread Pino Toscano
Hi, Debian recently started to set slightly more stricter C(XX)FLAGS for packages, and among those there are: -Wformat -Wformat-security -Werror=format-security There are few calls to error(), printk() and problem() which have no format string, causing them to fail the build of hurd.

[PATCH] make libdiskfs handle _PC_PATH_MAX

2011-10-18 Thread Pino Toscano
Hi, currently, querying (f)pathconf() for _PC_PATH_MAX return -1 and sets errno = EINVAL. At least to my reading of pathconf() in POSIX, when a variable has no limit pathconf() for it should return -1 and not change errno. For example: $ getconf PATH_MAX . getconf: pathconf: .: Invalid

Re: [PATCH] add missing format strings

2011-10-18 Thread Samuel Thibault
Pino Toscano, le Wed 19 Oct 2011 00:09:18 +0200, a écrit : Attached there is a git-format'ed patch to fix all (hopefully) of those cases. Applied, thanks! Samuel

Re: [PATCH] make libdiskfs handle _PC_PATH_MAX

2011-10-18 Thread Samuel Thibault
Pino Toscano, le Wed 19 Oct 2011 00:09:32 +0200, a écrit : At least to my reading of pathconf() in POSIX, when a variable has no limit pathconf() for it should return -1 and not change errno. Agreed, applied, thanks! Samuel