Re: [GSoC] Virtualization Using Hurd Mechanisms

2012-04-27 Thread Thomas Schwinge
Hi! On Thu, 12 Apr 2012 11:47:23 +0200, Pierre Thierry pie...@nothos.net wrote: this year I applied for a slot in Google's Summer of Code on the Hurd[1], to tackle virtualization à la Hurd. As I currently have no other commitments during the summer, I will be able work on this project between

Re: Next weeks: A question about gccgo

2012-04-27 Thread Svante Signell
On Fri, 2012-04-27 at 14:26 +0800, Thomas Schwinge wrote: Hi! I won't be available for one week starting today (completely, without Internet access, huh) :-) and the two weeks after won't be much better. After that, my focus will be GSoC and glibc. Hi Thomas, A quick question: What was the

Re: Next weeks: A question about gccgo

2012-04-27 Thread Thomas Schwinge
Hi! On Fri, 27 Apr 2012 08:55:32 +0200, Svante Signell s...@kth.se wrote: What was the conclusion after you implemented getcontext/setcontext in assembly? Would it be possible to integrate into Hurd or not? I would like to summarize my patches to the debian-hurd or gnu-hurd mailing list

[PATCH,HURD] hurd: compliance fixes for getgroups

2012-04-27 Thread Pino Toscano
Hi, attached there is a patch to fix a couple of issues with Hurd's getgroups(), namely when the requested number is 0 or when it is 0 but less than the actual number of groups that would be returned (this case is handled by simply returning the first n groups, instead of failing). Thanks,

[PATCH,HURD] hurd: compliance fixes for getlogin_r

2012-04-27 Thread Pino Toscano
Hi, attached there is a patch to fix few issues in Hurd's getlogin_r(): avoid a static buffer, and check for buffer shorter than necessary. Thanks, -- Pino Toscano hurd: compliance fixes for getlogin_r * do not make `login' static, as it would make getlogin_r no more reentrant * fail with

[PATCH,HURD] hurd: compliance fixes for ptsname_r

2012-04-27 Thread Pino Toscano
Hi, attached there is a patch to fix few issues in Hurd's ptsname_r(), mostly checking for more error conditions and making sure to set as errno and return the proper values on error conditions. Thanks, -- Pino Toscano hurd: compliance fixes for ptsname_r ptsname_r on failure returns the

Re: [PATCH,HURD] hurd: compliance fixes for getgroups

2012-04-27 Thread Roland McGrath
2012-04-27 Pino Toscano toscano.p...@tiscali.it * sysdeps/mach/hurd/getgroups.c (__getgroups): Return -1 and set EINVAL for negative `n' or less than `ngids'. The norm is to use all caps and no quotes to mention local variable names. You can also drop the (function) when it's

Re: [PATCH,HURD] hurd: compliance fixes for getlogin_r

2012-04-27 Thread Roland McGrath
You can just use string_t and no need for the XXX comment. libc code can use C99 freely these days, so use an inline initializing declaration rather than pre-declaring a new variable. I don't think there's any need to iniitalize the result buffer. We trust the RPC stubs to return a

Re: [PATCH,HURD] hurd: compliance fixes for ptsname_r

2012-04-27 Thread Roland McGrath
Compliance with what? Is there a standard that specifies ptsname_r? We don't use implicit boolean coercions, we use (buf != NULL). But unless there is a standard requiring that you diagnose a null pointer argument somehow, then it's actually better that it just crash. Thanks, Roland